Update DatasetCoreFactory to match Dataset Factory #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DatasetFactory` accepts both a DataSet and an array of Quads, while `DatasetCoreFactory` only has an array of Quads. Note that this is correct according to the spec (https://rdf.js.org/dataset-spec/#datasetcorefactory-interface), but I would argue that consistency is better.
|
I'm not sure. I think we should try to be true to the spec. I see that On the other hand changing the constructor could be a potential breaking change for implementations which strictly accept only arrays |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatasetFactoryaccepts both a DataSet and an array of Quads, whileDatasetCoreFactoryonly has an array of Quads. Note that this is correct according to the spec (https://rdf.js.org/dataset-spec/#datasetcorefactory-interface), but I would argue that consistency is better.