Add optional direction for literals #38
Conversation
🦋 Changeset detectedLatest commit: 14f33a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
data-model.d.ts
Outdated
|
|
||
| export interface DirectionalLanguage { | ||
| language: string; | ||
| direction?: 'ltr' | 'rtl' | ''; |
There was a problem hiding this comment.
In what cases would '' be used as input over undefined
There was a problem hiding this comment.
Because direction can be a falsy value, as discussed in the PR here: rdfjs/data-model-spec#175
That actually reminds me, we should also allow null here...
rubensworks
force-pushed
the
feature/direction
branch
from
951da64
to
14f33a2
Compare
|
This probably is something we should also (like #6) first discuss in the spec itself? |
Yes, we have rdfjs/data-model-spec#172 and rdfjs/data-model-spec#175 for this. But in any case, I think we'll want to put this on hold until w3c/rdf-concepts#79 is resolved. |
This adds typing support for base directions in literals, as discussed in rdfjs/data-model-spec#175