Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stream.d.ts so Stream extends AsyncIterable<Quad> #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gobengo
Copy link

@gobengo gobengo commented Dec 26, 2023

it might be a good idea to have it extend from stream.Readable too, but this is less opinionated. (node Readable implements AsyncIterable)

it might be a good idea to have it extend from stream.Readable too, but this is less opinionated. (node Readable implements AsyncIterable<Q>)
Copy link

changeset-bot bot commented Dec 26, 2023

⚠️ No Changeset found

Latest commit: 090d2d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gobengo gobengo marked this pull request as ready for review December 26, 2023 02:57
@gobengo
Copy link
Author

gobengo commented Dec 26, 2023

wdyt @rubensworks ?

@tpluscode
Copy link
Contributor

re #6

@woutermont
Copy link

Would be so handy! 👌

@bergos
Copy link
Member

bergos commented Jan 7, 2024

The types should always follow the WebIDL definitions in the specifications. Therefore, the stream spec would be the right place to discuss this topic.

If you consider making a proposal, address the concerns regarding performance expressed by the author of a widely used RDF/JS package.

@rubensworks
Copy link
Member

@gobengo I agree this could be useful, but as mentioned by @bergos, we should first add this to the streams spec, which requires concensus in the RDF/JS that this is the direction we want to go towards.
The performance issue raised in #6 may not be present anymore, but this would require some investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants