fix: Not trigger enter open for portal element #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 97.74% 97.87% +0.13%
==========================================
Files 13 13
Lines 797 799 +2
Branches 224 226 +2
==========================================
+ Hits 779 782 +3
+ Misses 18 17 -1 ☔ View full report in Codecov by Sentry. |
yoyo837
reviewed
Jan 24, 2024
tests/portal.test.jsx
Outdated
| import React, { createRef, StrictMode } from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import Trigger from '../src'; | ||
| import { awaitFakeTimer, placementAlignMap } from './util'; |
There was a problem hiding this comment.
Suggested change
| import { awaitFakeTimer, placementAlignMap } from './util'; | |
| import { placementAlignMap } from './util'; |
yoyo837
reviewed
Jan 24, 2024
| if (mergedOpen || inMotion) { | ||
| if ( | ||
| (mergedOpen || inMotion) && | ||
| popupEle?.contains(event.target as HTMLElement) |
There was a problem hiding this comment.
防止别人手工去调用 onMouseEnter，防御性的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve ant-design/ant-design#47093