fix: click on shadowDOM popup should not close it #480
Conversation
|
Warning Rate limit exceeded@afc163 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 22 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Walkthrough此次更改引入了一个新的辅助函数 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/index.tsx (1 hunks)
Additional comments not posted (2)
src/index.tsx (2)
275-282: 代码看起来不错！
inContainer函数正确实现了目标元素是否在指定容器或其 shadow root 内的逻辑，提高了代码的可读性和可维护性。代码更改已批准。
288-291: 代码看起来不错！
inPopupOrChild函数使用inContainer简化了检查事件目标是否包含在相关 DOM 元素中的逻辑，提高了代码结构。代码更改已批准。
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/shadow.test.tsx (1 hunks)
Additional comments not posted (6)
tests/shadow.test.tsx (6)
Line range hint
3-10: 代码看起来不错！
beforeEach和afterEach方法正确地设置和清理了测试环境。
Line range hint
12-22: 代码看起来不错！
Demo组件正确地渲染了Trigger组件和一个占位符div。
Line range hint
24-37: 代码看起来不错！
renderShadow函数正确地创建了一个 shadow DOM 并在其中渲染了Demo组件。
Line range hint
39-54: 代码看起来不错！
renderMultiLevelShadow函数正确地创建了一个嵌套的 shadow DOM 并在其中渲染了Demo组件。
212-223: 代码看起来不错！
CustomElement类正确地实现了connectedCallback和disconnectedCallback生命周期方法，并正确地附加了 shadow DOM。
227-318: 代码看起来不错！测试用例正确地验证了与 shadow DOM 元素交互时弹出窗口的行为，并涵盖了必要的场景。
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- global.d.ts (1 hunks)
Additional comments not posted (1)
global.d.ts (1)
1-6: 代码看起来不错！这个声明文件通过扩展 JSX 命名空间，添加了一个新的内置元素
custom-element。这允许在 TypeScript React 项目中使用<custom-element>作为有效的 JSX 元素。
React.DetailedHTMLProps类型用于定义custom-element的属性，它继承了React.HTMLAttributes<HTMLElement>中的标准 HTML 属性。HTMLElement类型被用作第二个泛型参数，以指定 DOM 元素的类型。这个声明是正确定义的，并遵循了 TypeScript 和 React 的类型定义。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 97.71% 97.85% +0.14%
==========================================
Files 13 13
Lines 787 793 +6
Branches 234 229 -5
==========================================
+ Hits 769 776 +7
+ Misses 18 17 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: afc163 <[email protected]>
|
Revert since: |
Summary by CodeRabbit
Summary by CodeRabbit
custom-element的支持，增强了与 React 应用的兼容性。Popup.Shadow组件的测试，确保其在与影子 DOM 元素和自定义组件交互时的正确行为。