Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Improve PHP 8.4+ support by avoiding implicitly nullable types #318

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

clue
Copy link
Member

@clue clue commented Jul 4, 2024

This changeset backports #317 from 3.x to 1.x to improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.

Builds on top of #317, #310 and #260, reactphp/promise#260, reactphp/dns#224, reactphp/stream#179, reactphp/async#87 and reactphp/promise-timer#70

@clue clue added this to the v1.16.0 milestone Jul 4, 2024
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants