Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the CompareResult interface include the difference percentage #79

Open
UnstoppableN opened this issue Aug 13, 2020 · 2 comments
Open

Can the CompareResult interface include the difference percentage #79

UnstoppableN opened this issue Aug 13, 2020 · 2 comments
Labels
enhancement

Comments

@UnstoppableN
Copy link

I can use the CompareResult to check if there are differences found.

It would be nice to also know the difference percentage which was found, this would help me to fine-tune the "allowedDifferenceInPercentPerPage" parameter to filter out some unwanted results.

Thank you for your help!
@finsterwalder
Copy link
Collaborator

Interesting idea... Could probably be done. I'll see, when I find some time...

@LennartKoot LennartKoot mentioned this issue Aug 10, 2021
Merged
@LennartKoot
Copy link
Contributor

@finsterwalder I provided a PR with a proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@finsterwalder @UnstoppableN @LennartKoot