Add difference percentages to CompareResult #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LennartKoot
changed the title
LennartKoot
commented
Aug 10, 2021
|
Thanks a lot for taking the time to improve PdfCompare! |
|
Version 1.1.60 is released and should land in maven central during the next couple of hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw #79 open for a while and decided to give a solution a try.
This PR will add
Map<Integer, Double> getPageDiffsInPercent()to theCompareResultinterface, exposing a collection of difference percentages mapped to their respective page index.There is a special case in
PageDiffCalculatorwheretotalPixelscan be zero. In this case I decided to return 0% when there are no differences, and 100% when there are differences, since there is nothing to calculate the percentage with. I'm not sure if this is the correct way to go, so please let me know if you have different ideas.