Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textmate definition for kotlin dsl #3377

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Nov 7, 2023

fix #3334

Before:
before

After:
after

@jdneo jdneo merged commit b623321 into redhat-developer:master Nov 9, 2023
4 checks passed
@jdneo jdneo deleted the cs/kotlin-textmate branch November 9, 2023 06:43
@jdneo jdneo added this to the End November 2023 milestone Nov 9, 2023
@rgrunber rgrunber removed this from the End November 2023 milestone Nov 9, 2023
@fwcd
Copy link
Contributor

fwcd commented Jan 15, 2024

Hm, while it's nice to have *.gradle.kts support in the upstream Java extension, it potentially also overrides the grammar of other Kotlin extensions (disclaimer: I'm the maintainer of this Kotlin extension). This is a bit frustrating since bugs in the grammar can potentially no longer be addressed by the Kotlin extensions themselves.

Perhaps, as an intermediate fix, the language support for Kotlin via this extension could be scoped to .gradle.kts files, so it doesn't affect other Kotlin files (which aren't handled by this language server anyway)?

Edit: Ah, I think the extension already does this, but uses source.kotlin as a scope. Ideally, a different scope should be used in that case, since those grammar apparently may still clash if another extension uses source.kotlin (?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host textmate definition for kotlin language
4 participants