Skip to content

Commit

Permalink
ci: update .github configs
Browse files Browse the repository at this point in the history
- sync with packit branch (PR#10)
- also remove tests from .distro
  • Loading branch information
pvalena committed Mar 22, 2024
1 parent 8069d40 commit 9bd4c34
Show file tree
Hide file tree
Showing 16 changed files with 118 additions and 286 deletions.
82 changes: 0 additions & 82 deletions .distro/newdracut.sh

This file was deleted.

1 change: 1 addition & 0 deletions .distro/source-git.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ specfile_path: .distro/dracut.spec
patch_generation_ignore_paths:
- .distro/
- .packit.yml
- .github/
patch_generation_patch_id_digits: 1
sync_changelog: true
files_to_sync:
Expand Down
52 changes: 0 additions & 52 deletions .distro/tests/add-luks-keys/Makefile

This file was deleted.

3 changes: 0 additions & 3 deletions .distro/tests/add-luks-keys/PURPOSE

This file was deleted.

59 changes: 0 additions & 59 deletions .distro/tests/add-luks-keys/runtest.sh

This file was deleted.

11 changes: 0 additions & 11 deletions .distro/tests/tests.yml

This file was deleted.

11 changes: 3 additions & 8 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
This pull request changes...
<description/>

## Changes
(cherry picked from commit ... )

## Checklist
- [ ] I have tested it locally
- [ ] I have reviewed and updated any documentation if relevant
- [ ] I am providing new code and test(s) for it

Fixes #
Resolves: RHEL-
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
queries: +security-extended,security-and-quality
Expand All @@ -47,7 +47,7 @@ jobs:
sudo apt -y install asciidoc gcc libkmod-dev libsystemd-dev pkg-config
- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@v3

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
25 changes: 10 additions & 15 deletions .github/workflows/container.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
name: Container
on:
schedule:
- cron: '30 11 * * *' # every day at 11:30 UTC
- cron: '30 11 * * *' # every day at 4:40
push:
branches: [ master ]
branches: [ main ]
paths:
- 'test/container/**'
- '.github/workflows/container.yml'
pull_request:
branches: [ master ]
branches: [ main ]
paths:
- 'test/container/**'
- '.github/workflows/container.yml'
Expand All @@ -30,27 +30,22 @@ jobs:
matrix:
config:
- { dockerfile: 'Dockerfile-Fedora-latest', tag: 'fedora:latest' }
- { dockerfile: 'Dockerfile-OpenSuse-latest', tag: 'opensuse:latest' }
- { dockerfile: 'Dockerfile-Arch', tag: 'arch:latest' }
- { dockerfile: 'Dockerfile-Debian', tag: 'debian:latest' }
- { dockerfile: 'Dockerfile-Gentoo', tag: 'gentoo:latest' }
- { dockerfile: 'Dockerfile-Ubuntu', tag: 'ubuntu:latest' }
steps:
- name: Check out the repo
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
# with:
# buildkitd-flags: --debug
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Set up env
run: echo "repository_owner=${GITHUB_REPOSITORY_OWNER,,}" >>${GITHUB_ENV}
- name: Build and Push Container
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
file: test/container/${{ matrix.config.dockerfile }}
tags: ghcr.io/${{env.repository_owner}}/${{ matrix.config.tag }}
tags: ghcr.io/${{ github.repository_owner }}/${{ matrix.config.tag }}
push: ${{ github.event_name == 'push' || github.event_name == 'schedule' }}
19 changes: 19 additions & 0 deletions .github/workflows/differential-shellcheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Differential ShellCheck
on:
pull_request:
branches: [ main ]

jobs:
test:
runs-on: ubuntu-20.04

steps:
- name: Repository checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@v5
with:
token: ${{ secrets.GITHUB_TOKEN }}
Loading

3 comments on commit 9bd4c34

@LaszloGombos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvalena awesome progress. Sad to see Test-18 gone from CI as that is the only UEFI boot. Any interest adding it back ?

@pvalena
Copy link
Contributor Author

@pvalena pvalena commented on 9bd4c34 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test removal was accidental, change should not go against the state of upstream. I do plan to enable all tests (or as much as possible). Not sure how it got here tbh.

@pvalena
Copy link
Contributor Author

@pvalena pvalena commented on 9bd4c34 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking this!

Please sign in to comment.