Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add search panel in state tab #1424

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nzsofia
Copy link

@nzsofia nzsofia commented Jun 17, 2023

This pull request adds a Search panel to the State Tab, which allows searching in the state tree by key, value or both. Users can jump between multiple search results and the tool will automatically scroll into view of the current result. Search is performed on an independent thread and does not block interactions with the browser or the Redux DevTools. The Search panel is hidden by default (and does not change any current Redux DevTools behavior). It can be activated in the Settings (State Tree submenu).

Solves #989

Search initial state

Search result1

Search result2

Settings

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2023

⚠️ No Changeset found

Latest commit: a023f15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nzsofia nzsofia force-pushed the feature/add-search-panel-in-state-tab branch from 02f1462 to 519d33a Compare June 17, 2023 20:29
@nzsofia nzsofia force-pushed the feature/add-search-panel-in-state-tab branch from 519d33a to 88ad68d Compare July 28, 2023 08:18
@nzsofia
Copy link
Author

nzsofia commented Jul 28, 2023

@Methuselah96 any chance this can get merged? I can also adjust things, if necessary.

@bitqiang
Copy link

I also really need the search function, are there any plans to merge it?

@80avin
Copy link
Contributor

80avin commented Oct 1, 2023

This is impressive and really well implemented.
I also had created a PR #1305 for search functionality, while mine is a bit more powerful as it supports JSONPath expressions, but the UI implemented in this PR is far superior to mine.

@kieter
Copy link

kieter commented Oct 25, 2023

Would love to see this merged! Amazing work @nzsofia!

@Methuselah96 pretty please 😉

@rjvarona
Copy link

Yo would love this merged in this is great work @nzsofia !!!

@naakheel
Copy link

+1 Good stuff @nzsofia
Can we have this merged?

@nzsofia
Copy link
Author

nzsofia commented Oct 27, 2023

I will rebase the branch to main, maybe that will help getting it merged. It would be really great to have this functionality in the official tool🙂

@nzsofia nzsofia force-pushed the feature/add-search-panel-in-state-tab branch from 88ad68d to 606daf7 Compare October 27, 2023 10:22
@mveraldi-cisco
Copy link

Are there any news about it? I would love to have this functionality

@j4ckp0t85
Copy link

interesting feature. any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants