Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split large messages sent from background page to devpanel #1706

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

Methuselah96
Copy link
Member

Related: #1705

Chrome has a maximum message length. We work around this when passing messages between the content script and background page by splitting messages. Since we now need to rely on message passing between the background page and the monitors, we need to add message splitting there as well.

This fixes a preexisting bug where the Redux DevTools don't work for apps with large state when using the DevTools panel in Incognito.

Copy link

changeset-bot bot commented Aug 4, 2024

🦋 Changeset detected

Latest commit: 7e8798d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
remotedev-redux-devtools-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Methuselah96 Methuselah96 mentioned this pull request Aug 4, 2024
6 tasks
@Methuselah96 Methuselah96 merged commit 2163bc3 into main Aug 4, 2024
1 check passed
@Methuselah96 Methuselah96 deleted the message-splitting-2 branch August 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant