-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to React 19 #4409
base: master
Are you sure you want to change the base?
Migrate to React 19 #4409
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ede814c - Browse repository at this point
Copy the full SHA ede814cView commit details -
Set
@types/react
and@types/react-dom
to temporary types packages- We set the `@types/react` and `@types/react-dom` package resolutions to `npm:types-react` and `npm:types-react-dom` according to the React 19 migration guide.
Configuration menu - View commit details
-
Copy full SHA for 02e5023 - Browse repository at this point
Copy the full SHA 02e5023View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4475c22 - Browse repository at this point
Copy the full SHA 4475c22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 662fd38 - Browse repository at this point
Copy the full SHA 662fd38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98c7d16 - Browse repository at this point
Copy the full SHA 98c7d16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6070776 - Browse repository at this point
Copy the full SHA 6070776View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbc8819 - Browse repository at this point
Copy the full SHA fbc8819View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a36c6a - Browse repository at this point
Copy the full SHA 6a36c6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3f7fbf - Browse repository at this point
Copy the full SHA d3f7fbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5c7bb1 - Browse repository at this point
Copy the full SHA b5c7bb1View commit details -
Remove redundant
act
wrappers aroundfireEvent
method calls- According to latest documentation of `@testing-library/react`, `fireEvent` methods are already wrapped inside `act` calls making manual wrapping unnecessary.
Configuration menu - View commit details
-
Copy full SHA for 3dcee2f - Browse repository at this point
Copy the full SHA 3dcee2fView commit details -
Workaround issue
userEvent
not working with fake timers- There currently seems to be an issue involving `sinon` fake timers used by `vitest`, `@testing-library/react` only supporting `jest` fake timers and `@testing-library/user-event` using `setTimeout` internally to simulate user actions such as button presses. Currently `@testing-library/react` only works with `jest` fake timers, which means if there are any component updates while `sinon` fake timers are running in `vitest` , `@testing-library/react` will not catch it and things start to break. - To workaround this issue, We have to setup the `user` by calling `userEvent.setup({ delay: null })`. The reason why We do this is because `@testing-library/user-event` uses `setTimeout` internally which cannot be awaited in a test while fake timers are running as it can cause the tests to indefinitely hang. So the current workaround is to disable the `delay` functionality of `userEvent` and prevent it from calling `setTimeout`. We also have to pass in `shouldAdvanceTime: true` to `vi.useFakeTimers()` as it can get around the issue of `@testing-library/react` not tracking `sinon` fake timers in `vitest`.
Configuration menu - View commit details
-
Copy full SHA for 783ae4b - Browse repository at this point
Copy the full SHA 783ae4bView commit details -
Fix test names in
fork.test.ts
- Fixed test names in `fork.test.ts` which could cause the terminal to flicker in Windows.
Configuration menu - View commit details
-
Copy full SHA for 17d9f53 - Browse repository at this point
Copy the full SHA 17d9f53View commit details -
Fix issue with
console
spy insidebuildHooks.test.tsx
- `.mockReset()` should not be called in spies since it calls `.mockClear()` and returns the implementation to its **initial** form. In this case it was silencing some of the `act` related warnings emitted by `@testing-library/react` which needed to be resolved since they were calling issues. So `.mockReset()` calls on spies need to be changed to `.mockRestore()` calls since `.mockRestore()` restores the implementation to its **original** form.
Configuration menu - View commit details
-
Copy full SHA for 5bef2cd - Browse repository at this point
Copy the full SHA 5bef2cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f32fbce - Browse repository at this point
Copy the full SHA f32fbceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4238059 - Browse repository at this point
Copy the full SHA 4238059View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcfd0a7 - Browse repository at this point
Copy the full SHA fcfd0a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b8692f - Browse repository at this point
Copy the full SHA 0b8692fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a2415f - Browse repository at this point
Copy the full SHA 1a2415fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93ca270 - Browse repository at this point
Copy the full SHA 93ca270View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55af373 - Browse repository at this point
Copy the full SHA 55af373View commit details -
Configuration menu - View commit details
-
Copy full SHA for 529d0ca - Browse repository at this point
Copy the full SHA 529d0caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5095dfc - Browse repository at this point
Copy the full SHA 5095dfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcc39cd - Browse repository at this point
Copy the full SHA bcc39cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bac006 - Browse repository at this point
Copy the full SHA 5bac006View commit details -
Configuration menu - View commit details
-
Copy full SHA for f51a37f - Browse repository at this point
Copy the full SHA f51a37fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc2220 - Browse repository at this point
Copy the full SHA 9bc2220View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0eace5 - Browse repository at this point
Copy the full SHA f0eace5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f5e6e6 - Browse repository at this point
Copy the full SHA 4f5e6e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 567ff3b - Browse repository at this point
Copy the full SHA 567ff3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b753ee - Browse repository at this point
Copy the full SHA 8b753eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7555deb - Browse repository at this point
Copy the full SHA 7555debView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8314e26 - Browse repository at this point
Copy the full SHA 8314e26View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8b9ade - Browse repository at this point
Copy the full SHA a8b9adeView commit details -
Fix issues related to
console
spies in `immutableStateInvariantMidd……leware.test.ts`
Configuration menu - View commit details
-
Copy full SHA for 72fb1ac - Browse repository at this point
Copy the full SHA 72fb1acView commit details -
Fix issues related to
console
spies in `serializableStateInvariantM……iddleware.test.ts`
Configuration menu - View commit details
-
Copy full SHA for d4247be - Browse repository at this point
Copy the full SHA d4247beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a1028c - Browse repository at this point
Copy the full SHA 8a1028cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 530d3f5 - Browse repository at this point
Copy the full SHA 530d3f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c630a97 - Browse repository at this point
Copy the full SHA c630a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ff87ab - Browse repository at this point
Copy the full SHA 0ff87abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8273a1b - Browse repository at this point
Copy the full SHA 8273a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7be6ce1 - Browse repository at this point
Copy the full SHA 7be6ce1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 153ecdd - Browse repository at this point
Copy the full SHA 153ecddView commit details -
Configuration menu - View commit details
-
Copy full SHA for f70d15b - Browse repository at this point
Copy the full SHA f70d15bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e0add3 - Browse repository at this point
Copy the full SHA 3e0add3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cea84ed - Browse repository at this point
Copy the full SHA cea84edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6086099 - Browse repository at this point
Copy the full SHA 6086099View commit details -
Add
areErrorsEqual
equality tester- This was done to make sure `toHaveBeenCalledWith` will fail if we pass in the wrong Error constructor. For example the assertion will now fail if we pass in an `Error` instead of a `TypeError`.
Configuration menu - View commit details
-
Copy full SHA for 37c9c0e - Browse repository at this point
Copy the full SHA 37c9c0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4283dd4 - Browse repository at this point
Copy the full SHA 4283dd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed90d0d - Browse repository at this point
Copy the full SHA ed90d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9759ad1 - Browse repository at this point
Copy the full SHA 9759ad1View commit details -
Remove
jest-snapshot
fromresolutions
field- This was done because it was causing the unit tests in example workspaces to fail.
Configuration menu - View commit details
-
Copy full SHA for 42315cb - Browse repository at this point
Copy the full SHA 42315cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed1f53e - Browse repository at this point
Copy the full SHA ed1f53eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d16152 - Browse repository at this point
Copy the full SHA 9d16152View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5de1c5 - Browse repository at this point
Copy the full SHA b5de1c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6bb978 - Browse repository at this point
Copy the full SHA b6bb978View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb2a7c - Browse repository at this point
Copy the full SHA 8fb2a7cView commit details