Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oauth backend, enable login for local users #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hrantzsch
Copy link
Contributor

add basic oauth backend. also removed unused base folder

@dahoo
Copy link
Member

dahoo commented Dec 18, 2015

The tests are failing. Did you forget to add oauth2 to the requirements or something like that?

@illing2005
Copy link
Member

You removed "rest_framework" from installed apps. That might be the problem:
https://github.com/refugeehackathon/interpreteer-backend/pull/46/files#diff-29

Did you also remove the Facebook Login?

@hrantzsch
Copy link
Contributor Author

woops, forgot to add new requirements

@hrantzsch
Copy link
Contributor Author

Ok, checks are being passed now.
Did you see that we removed the base-stuff as well? Frontend would run on it's own then and there's no route that belongs to '/'. Christian argues we could redirect to api/docs or something similar.

@dahoo
Copy link
Member

dahoo commented Dec 21, 2015

👍

@illing2005
Copy link
Member

Still wondering why you removed rest_framework from INSTALLED_APPS
https://github.com/refugeehackathon/interpreteer-backend/pull/46/files#diff-29

Also it would be great, if you could add some tests :)

@dahoo
Copy link
Member

dahoo commented Dec 21, 2015

Oh, forgot that. It's indeed missing, I get the error TemplateDoesNotExist at /api/offers/.

@hrantzsch
Copy link
Contributor Author

Sorry, of course you are right. rest_framework was not supposed to be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants