Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #62

Merged
merged 5 commits into from
Apr 21, 2021
Merged

Update all dependencies #62

merged 5 commits into from
Apr 21, 2021

Conversation

expenses
Copy link
Contributor

I've tried to be pretty conservative here and not modernise the code that doesn't need to be. This unfortunately still doesn't fix #59 :^( . When I run it with env METAL_DEVICE_WRAPPER_TYPE=1 I do get a panic with:
validateFunctionArguments:3727: failed assertion 'Fragment Function(main0): argument v_69[0] from buffer(0) with offset(0) and length(176) has space for 176 bytes, but argument has a length(224).'

I'll see if switching to naga fixes this, and if not, I'll have a go at a gfx backend.

@repi repi merged commit 36ba69e into repi:master Apr 21, 2021
@repi
Copy link
Owner

repi commented Apr 21, 2021

As the renderer is so simple was a bit curious trying out wgpu crate on top of gfx later for a renderer instead of pure Metal. So if you want to take on some more work and experiment that that would be cool!

@expenses
Copy link
Contributor Author

As the renderer is so simple was a bit curious trying out wgpu crate on top of gfx later for a renderer instead of pure Metal. So if you want to take on some more work and experiment that that would be cool!

That'd be ideal, but we've just added a pipeline cache for the gfx metal backend (gfx-rs/gfx#3719) and it might be a while until that's usable from wgpu. I'll see how things go!

@expenses expenses mentioned this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shaders run for 4 seconds and then hang.
2 participants