feat: add host preflights for all needed ports #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checks if all needed ports are available on the server prior to start the installation.
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
make sure preflights are failing if some ports are in use.
ajp-io
reviewed
Sep 20, 2024
| outcomes: | ||
| - fail: | ||
| when: "connection-refused" | ||
| message: Port 30000/TCP is required, but the connection was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). |
There was a problem hiding this comment.
I need to better understand this one to comment on the wording, but this can be fine for now.
| message: Port 30000/TCP is required, but the connection was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). | ||
| - fail: | ||
| when: "address-in-use" | ||
| message: Port 30000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. |
There was a problem hiding this comment.
When we merge Ethan's port relocation changes, we can update this:
Suggested change
| message: Port 30000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. | |
| message: Port 30000/TCP is required, but another process is already listening on it. To proceed, relocate the conflicting process or specify an available port using --admin-console-port. |
| message: Port 50000/TCP is required, but the connection was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). | ||
| - fail: | ||
| when: "address-in-use" | ||
| message: Port 50000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. |
There was a problem hiding this comment.
When we merge Ethan's port relocation changes, we can update this:
Suggested change
| message: Port 50000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. | |
| message: Port 50000/TCP is required, but another process is already listening on it. To proceed, relocate the conflicting process or specify an available port using --local-artifact-mirror-port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checks if all needed ports are available on the server prior to start the installation.