-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-90118 || Improve Email configuration to take into account possible deployment under path #1976
Open
APiankouski
wants to merge
6
commits into
develop
Choose a base branch
from
EPMRPP-90118
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
EPMRPP-90118 || Improve Email configuration to take into account possible deployment under path #1976
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
943f101
EPMRPP-90118 || Improve Email configuration to take into account poss…
APiankouski 996e391
EPMRPP-90118 || Improve Email configuration to take into account poss…
APiankouski 51962b7
EPMRPP-90118 || Improve Email configuration to take into account poss…
APiankouski b2c6f68
EPMRPP-90118 || Improve Email configuration to take into account poss…
APiankouski 97cbc83
EPMRPP-90118 || Improve Email configuration to take into account poss…
APiankouski 6c71da8
EPMRPP-90118 || Improve Email configuration to take into account poss…
APiankouski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,8 +33,10 @@ private LinkGenerator() { | |
//static only | ||
} | ||
|
||
public static String generateLaunchLink(String baseUrl, String projectName, String id) { | ||
return StringUtils.isEmpty(baseUrl) ? null : baseUrl + UI_PREFIX + projectName + LAUNCHES + id; | ||
public static String generateLaunchLink(String baseUrl, String path, String projectName, String id) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
path = "/".equals(path) ? "" : path.replace("/api", ""); | ||
return StringUtils.isEmpty(baseUrl) ? null | ||
: baseUrl + path + UI_PREFIX + projectName + LAUNCHES + id; | ||
} | ||
|
||
public static String composeBaseUrl(HttpServletRequest request) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,12 +47,15 @@ | |
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.ExtendWith; | ||
import org.mockito.InjectMocks; | ||
import org.mockito.Mock; | ||
import org.mockito.junit.jupiter.MockitoExtension; | ||
import org.springframework.context.ApplicationEventPublisher; | ||
import org.springframework.core.env.Environment; | ||
import org.springframework.test.util.ReflectionTestUtils; | ||
|
||
/** | ||
* @author <a href="mailto:[email protected]">Ihar Kahadouski</a> | ||
|
@@ -75,12 +78,21 @@ class FinishLaunchHandlerImplTest { | |
@Mock | ||
private ApplicationEventPublisher publisher; | ||
|
||
@Mock | ||
private Environment env; | ||
|
||
@InjectMocks | ||
private FinishLaunchHandlerImpl handler; | ||
|
||
@InjectMocks | ||
private StopLaunchHandlerImpl stopLaunchHandler; | ||
|
||
@BeforeEach | ||
void setUp() { | ||
when(env.getProperty("server.servlet.context-path")).thenReturn("/"); | ||
ReflectionTestUtils.setField(handler, "path", env.getProperty("server.servlet.context-path")); | ||
} | ||
|
||
@Test | ||
void finishLaunch() { | ||
FinishExecutionRQ finishExecutionRQ = new FinishExecutionRQ(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 103).