Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: shorten outdated grace period #56

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Jun 6, 2023

While working up #55, I realized that our problems might (largely) be
explainable by having a much longer than expected grace period. While
#55 might be a reasonable or useful change, it seems like running with
a tighter tollerance might be useful.

I chose 10ms somewhat arbitrarily. I think +/- an order of magnitude
would be fair.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #56 (f04cb53) into master (4d78f5c) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   86.22%   86.32%   +0.10%     
==========================================
  Files           8        8              
  Lines         530      534       +4     
==========================================
+ Hits          457      461       +4     
  Misses         52       52              
  Partials       21       21              
Impacted Files Coverage Δ
quartz/scheduler.go 92.81% <100.00%> (+0.16%) ⬆️
quartz/util.go 90.00% <100.00%> (ø)

Copy link
Owner

@reugn reugn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the concern. What do you think about adding it to StdSchedulerOptions? Cron's minimum interval is one second, so we can set the default value to 100 milliseconds.

@tychoish
Copy link
Contributor Author

I see the concern. What do you think about adding it to StdSchedulerOptions? Cron's minimum interval is one second, so we can set the default value to 100 milliseconds.

Done!

@tychoish
Copy link
Contributor Author

I've given this another pass, and I think the documentation and test cases are in better shape now.

Please tell me what you think!

@tychoish tychoish requested a review from reugn July 19, 2023 22:37
@reugn reugn merged commit 0a4c573 into reugn:master Jul 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants