Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend shell job #64

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Conversation

rfyiamcool
Copy link
Contributor

change

extend shell job

  1. add stdout, stderr, result.
  2. bash command is preferred,sh command is used only when bash command does not exist. because bash command is more complete than sh command.
  3. add ut for shell execute.

Signed-off-by: rfyiamcool <[email protected]>
Signed-off-by: rfyiamcool <[email protected]>
Signed-off-by: rfyiamcool <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Merging #64 (1004154) into master (485d76b) will decrease coverage by 0.12%.
Report is 2 commits behind head on master.
The diff coverage is 87.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   90.13%   90.01%   -0.12%     
==========================================
  Files           8        8              
  Lines         527      541      +14     
==========================================
+ Hits          475      487      +12     
- Misses         33       34       +1     
- Partials       19       20       +1     
Files Changed Coverage Δ
quartz/job.go 97.18% <87.50%> (-2.82%) ⬇️

}

// invalid command
stdoutShell := "invliad_command"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdoutShell := "invliad_command"
stdoutShell := "invalid_command"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 done

Signed-off-by: rfyiamcool <[email protected]>
Signed-off-by: rfyiamcool <[email protected]>
@reugn reugn merged commit 6c23d5c into reugn:master Aug 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants