Recognizer input : insert ch in caret_pos

[shewer]

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #
caret_pos 不在字尾時
ab^cd key : 'z' input = abcdz <--- 錯誤
ab^cd key: 'z' input = abzcd < -- 修正

Feature

Describe feature of pull request

Unit test

• Done

Manual test

• Done

Code Review

1. Unit and manual test pass
2. GitHub Action CI pass
3. At least one contributor reviews and votes
4. Can be merged clean without conflicts
5. PR will be merged by rebase upstream base

Additional Info

[lotem]

Thanks. LGTM

[lotem]

Question: does it work as expected after the fix?

After recognizer handled the pattern abzcd, the new inputabz^cd will probably not be given to matcher as abzcd but as abz, ending at cursor position.

[shewer]

Question: does it work as expected after the fix?

After recognizer handled the pattern abzcd, the new inputabz^cd will probably not be given to matcher as abzcd but as abz, ending at cursor position.

原來的 recoginzer ab^cdz
變更後 recognizer 使用 abc^dz
recoginzer 收下後
ctx._input = abz^cd
compisition.input = abz

• Compose() reset comp.input = abz
  

  librime/src/rime/engine.cc

  Lines 155 to 157 in bcb3555

  	const string active_input = ctx->input().substr(0, ctx->caret_pos());
  	DLOG(INFO) << "active input: " << active_input;
  	comp.Reset(active_input);

-- matcher 使用 comp.input

librime/src/rime/gear/matcher.cc

Line 26 in bcb3555

auto match = patterns_.GetMatch(segmentation->input(), *segmentation);

這讓又產生一個疑問 recognizer patters 主要工作是確認
加入的 ch 是否在符合patterns 但是要比較 ctx._input 還是 ctx._input.substr(0, carte_pos) 才收下呢

從 Compose() 以後的 carte_pos 後的字串基本上是不管的

[lotem]

我有點兒腦霧。理不清楚。不要緊以後再看。
用來解決什麼實際問題，有具體的例子嗎。

[shewer]

一般正常輸入時 的確是 在 context.input 後面加上 字元，比較pattern
可是 當 caret_pos(^: caret_pos) 在 字串中間時 ， active_input += ch 比較pattern 有點怪
abc^def 輸入z 應該 是 abcz^def 而不是 abc^defz