perf(common): replace std unordered_map with boost's #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter has considerable performance improvement compared with the former.
lotem
reviewed
Sep 18, 2024
| @@ -48,7 +48,7 @@ using std::string; | |||
| using std::vector; | |||
|
|
|||
| template <class Key, class T> | |||
| using hash_map = std::unordered_map<Key, T>; | |||
| using hash_map = boost::unordered_map<Key, T>; | |||
| template <class T> | |||
| using hash_set = std::unordered_set<T>; | |||
There was a problem hiding this comment.
What about unordered_set? Will this get the same performance improvement?
Let alone performance, I'd be very frustrated to learn that hash_map and hash_set come from different libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes # N/A
Feature
Describe feature of pull request
The latter has considerable performance improvement compared with the former.
Unit test
Manual test
Code Review
Additional Info