Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression benchmarks #179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kamahori
Copy link
Contributor

Fixed some problems about LHCb/NanoAOD/ATLAS benchmarks.

To compress properly,

  • Make them use hadd command.
  • Make them delete files after benchmarking not to suppress storage capacity.

Also, to save time,

  • Change number of iterations from 5 to 3.
  • Change file used in NanoAOD BM to smaller one (Run2012B_DoubleElectron.root).
  • Change file used in ATLAS BM to 2 smaller files: atlasopendata_mc_117050.ttbar_lep.root (Monte Carlo data) and atlasopendata_DataMuons.root (real data).

@kamahori
Copy link
Contributor Author

Output of these benchmarks can be found here.

@vgvassilev
Copy link
Member

We should not use the disk/ssd in cases where we do not want to measure their effects. The benefits are mostly two:

  • Using ramdisk is usually faster and thus we can execute more benchmarks for given time;
  • We increase the life of the benchmarking machines -- usually they are expensive, physical hard-to-get machines.

Could you use GetTempFs and operate on the ramdisk?

@oshadura oshadura requested a review from stwunsch August 25, 2020 07:48
@oshadura
Copy link
Collaborator

@stwunsch do you think data sets (e,g, ATLAS) and timing of benchmark is appropriate?

@stwunsch
Copy link
Collaborator

Could you tell me how long the benchmarks run?

@oshadura
Copy link
Collaborator

@stwunsch here is output from Keisuke: #179 (comment)

@oshadura
Copy link
Collaborator

oshadura commented Aug 25, 2020

@kamahori is it really take 122 min for Atlas benchmark? @stwunsch I will better checkout PR by myself 👍

@kamahori
Copy link
Contributor Author

@oshadura Yes it actually took about 2hrs with my machine.

@stwunsch
Copy link
Collaborator

stwunsch commented Aug 25, 2020

i thought we target a runtime of about 30s per benchmark ;) is this realistic for these kind of benchmarks?

@stwunsch
Copy link
Collaborator

I think you can set the repetitions down to 1. We get the statistcs anyway by running twice a day!

@stwunsch
Copy link
Collaborator

Then, here is a small NanoAOD(-like) sample: https://root.cern/files/rootbench/SMHiggsToZZTo4L.root

@kamahori
Copy link
Contributor Author

How about number of levels? Do we really need to measure with 3 different levels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants