Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Choose different read and write rate for the hardware components #1570

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

[Feature] Choose different read and write rate for the hardware components #1570

wants to merge 23 commits into from

Commits on Sep 11, 2024

  1. added the initial changes for read_rate and write_rate

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    96a8c3f View commit details
    Browse the repository at this point in the history

  2. add last read and write cycle time to control the rate

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    79707c1 View commit details
    Browse the repository at this point in the history

  3. add read write rate parsing from the ros2_control tag in component pa… 

    …rser
    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1a799d0 View commit details
    Browse the repository at this point in the history

  4. fix the component info using the rw_rate in the HardwareInfo

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    322db85 View commit details
    Browse the repository at this point in the history

  5. Add tests to the parsed rw_rate

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1eb91c8 View commit details
    Browse the repository at this point in the history

  6. change the rw_rate between system and sensor interface for tests

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d336e18 View commit details
    Browse the repository at this point in the history

  7. for hardware read and write period switch to rclcpp::Duration

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9699eaf View commit details
    Browse the repository at this point in the history

  8. update the state of the system test component similar to actuator tes… 

    …t component
    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    593f360 View commit details
    Browse the repository at this point in the history

  9. Add a test for a different components update rate and verifying with … 

    …test components
    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0580b3f View commit details
    Browse the repository at this point in the history

  10. Add more checks and clean a part of the testing code

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    779d495 View commit details
    Browse the repository at this point in the history

  11. Add the test case of the deactivated case

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d0abc30 View commit details
    Browse the repository at this point in the history

  12. parameterize the tests for flexibility

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5250a9f View commit details
    Browse the repository at this point in the history

  13. Test also for the unconfigured and finalized lifecycle states

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bc6dd6d View commit details
    Browse the repository at this point in the history

  14. Add testing for the component parser of the read and write rate

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    189425f View commit details
    Browse the repository at this point in the history

  15. Update documentation and the release notes

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    108a4bc View commit details
    Browse the repository at this point in the history

  16. Parse the actual period to the read and write methods

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    70010f7 View commit details
    Browse the repository at this point in the history

  17. Use the current time to trigger the components based on their update … 

    …rate
    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7f05af8 View commit details
    Browse the repository at this point in the history

  18. Update tests to reflect the change w.r.t reality

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    474efb4 View commit details
    Browse the repository at this point in the history

  19. update the logic to use the clock to initialize the last read and wri… 

    …te cycle time
    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    41233fc View commit details
    Browse the repository at this point in the history

  20. Fix the test_component_interface for missing valid node_clock_interface

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9daf9ab View commit details
    Browse the repository at this point in the history

  21. use the internal mutex to skip when occupied by other nonRT things

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5509eee View commit details
    Browse the repository at this point in the history

  22. add missing copying of read and write time in the copy constructor

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2edfb19 View commit details
    Browse the repository at this point in the history

  23. added the corner case of the simulation

    @saikishor
    saikishor committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    dbfe3a0 View commit details
    Browse the repository at this point in the history