-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example 13] Multi-robot system with lifecycle management #417
base: master
Are you sure you want to change the base?
[Example 13] Multi-robot system with lifecycle management #417
Conversation
825aeec
to
2cf711c
Compare
@Mergifyio backport iron humble |
🟠 Waiting for conditions to match
|
c2a4a77
to
cbc3fbc
Compare
7. Set ``RRBotSystemPositionOnly`` in unconfigured state, and deactivate its joint state broadcaster. Also restart global joint state broadcaster. Call | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the 7th point, I don't get the same result. For me all the robots stopped moving and the following is the output from list_controllers
command
$ ros2 control list_controllers
rrbot_joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] inactive
threedofbot_pid_gain_controller[forward_command_controller/ForwardCommandController] active
threedofbot_joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active
rrbot_with_sensor_joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active
joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] inactive
rrbot_with_sensor_fts_broadcaster[force_torque_sensor_broadcaster/ForceTorqueSensorBroadcaster] active
rrbot_with_sensor_position_controller[forward_command_controller/ForwardCommandController] active
rrbot_position_controller[forward_command_controller/ForwardCommandController] inactive
rrbot_external_fts_broadcaster[force_torque_sensor_broadcaster/ForceTorqueSensorBroadcaster] active
threedofbot_position_controller[forward_command_controller/ForwardCommandController] active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. The joint_state_broadcaster cannot be activated again (the cli returns a success, but it is not activated).
Because of the verbose output described with ros-controls/ros2_control#1103 I was not able to see any error message from the controller_manager. Neither in rqt_console or rqt_robot_monitor I see any error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting back. If I get some time, I will try to take a look at this issue.
Thank you for reporting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be fixed in the meantime?
4ad9687
to
77783f2
Compare
77783f2
to
79f8249
Compare
This pull request is in conflict. Could you fix it @christophfroehlich? |
1 similar comment
This pull request is in conflict. Could you fix it @christophfroehlich? |
Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]>
Co-authored-by: Denis Štogl <[email protected]> Co-authored-by: bailaC <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
1d755fd
to
4a2d4f5
Compare
709fa2c
to
c5f20f6
Compare
This is a rewrite of #187 including StoglRobotics-forks#7.
Open questions for me:
The problems discussed in the latter PR are summarized in Ressource manager hangs up on lifecycle changes ros2_control#1103. I'd say we can add this example even if the problem is not fixed yet.It uses the rrbot URDF from example_4 and example_5. Should I generate new ones inside example 15? Currently, there is also the FTS broadcaster etc in Rviz, but maybe this wouldn't be necessary and we could just use the same Rrbot instead.-> we decided in the WG meeting to reuse descriptions for the multi-robot examples./joint_states
topic and it seemed to work (better than now, without the necessity of reloading the JSB). The only difference is that with the global one, all joints are within one message. Why would someone need this for multiple robots?