Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example 13] Multi-robot system with lifecycle management #417

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 25, 2023

This is a rewrite of #187 including StoglRobotics-forks#7.

Open questions for me:

  • The problems discussed in the latter PR are summarized in Ressource manager hangs up on lifecycle changes ros2_control#1103. I'd say we can add this example even if the problem is not fixed yet.
  • It uses the rrbot URDF from example_4 and example_5. Should I generate new ones inside example 15? Currently, there is also the FTS broadcaster etc in Rviz, but maybe this wouldn't be necessary and we could just use the same Rrbot instead. -> we decided in the WG meeting to reuse descriptions for the multi-robot examples.
  • Why should one use a global joint state broadcaster? In the original version it was not configured properly, and all "individual" JSB published on the /joint_states topic and it seemed to work (better than now, without the necessity of reloading the JSB). The only difference is that with the global one, all joints are within one message. Why would someone need this for multiple robots?

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport iron humble

Copy link
Contributor

mergify bot commented Dec 25, 2023

backport iron humble

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

example_13/README.md Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
example_13/doc/userdoc.rst Outdated Show resolved Hide resolved
Comment on lines +421 to +428
7. Set ``RRBotSystemPositionOnly`` in unconfigured state, and deactivate its joint state broadcaster. Also restart global joint state broadcaster. Call

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the 7th point, I don't get the same result. For me all the robots stopped moving and the following is the output from list_controllers command

$ ros2 control list_controllers
rrbot_joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] inactive  
threedofbot_pid_gain_controller[forward_command_controller/ForwardCommandController] active    
threedofbot_joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active    
rrbot_with_sensor_joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] active    
joint_state_broadcaster[joint_state_broadcaster/JointStateBroadcaster] inactive  
rrbot_with_sensor_fts_broadcaster[force_torque_sensor_broadcaster/ForceTorqueSensorBroadcaster] active    
rrbot_with_sensor_position_controller[forward_command_controller/ForwardCommandController] active    
rrbot_position_controller[forward_command_controller/ForwardCommandController] inactive  
rrbot_external_fts_broadcaster[force_torque_sensor_broadcaster/ForceTorqueSensorBroadcaster] active    
threedofbot_position_controller[forward_command_controller/ForwardCommandController] active

Copy link
Contributor Author

@christophfroehlich christophfroehlich Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. The joint_state_broadcaster cannot be activated again (the cli returns a success, but it is not activated).
Because of the verbose output described with ros-controls/ros2_control#1103 I was not able to see any error message from the controller_manager. Neither in rqt_console or rqt_robot_monitor I see any error message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting back. If I get some time, I will try to take a look at this issue.
Thank you for reporting it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be fixed in the meantime?

Copy link
Contributor

mergify bot commented Feb 17, 2024

This pull request is in conflict. Could you fix it @christophfroehlich?

1 similar comment
Copy link
Contributor

mergify bot commented Feb 18, 2024

This pull request is in conflict. Could you fix it @christophfroehlich?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants