Remove performance_test from rosdistro #42459
Conversation
Signed-off-by: LanderU <[email protected]>
LanderU
requested review from
nuclearsandwich,
cottsay and
quarkytale
as code owners
github-actions
bot
added
end-of-life
|
This pull request changes files for a ROS distribution that is no longer supported (End Of Life) and the distribution will not have any future syncs to include this change. |
audrow
added
the
changes requested
|
We normally don't modify EOL distros. I think removing a package may be an exception. I've asked in the OSRF slack. |
There was a problem hiding this comment.
For preventing the build failures this is overkill. To do that specifically you'll want to only remove the release stanzas. If you remove the entire entry you will also remove the indexing and documentation which means that the community won't be able to discover your packages anywhere near as easily.
did not get any feedback: https://gitlab.com/ApexAI/performance_test/-/issues/166
Note that you @ mentioned one developer on your own repository, which I don't think that they're watching. If you want help please use one of the support channels (such as robotics.stackexchange.com ) and not rely on a single ping of a single developer on a non-standard channel.
However I think that there's likely just some things that can be fixed to resolve your issues.
For example I took a quick look at the the Hdev test looks like it's failing for some linting errrors: https://build.ros2.org/job/Hdev__performance_test__ubuntu_jammy_amd64/79/ You should be able to fix those.
It is also flagged that the released version was out of date. Has it been attempted to review the errors and update the release?
| @@ -4427,21 +4427,6 @@ repositories: | |||
| url: https://github.com/ros-perception/perception_pcl.git | |||
| version: ros2 | |||
| status: maintained | |||
| performance_test: | |||
There was a problem hiding this comment.
It looks like the new release has fixed the builds in rolling: https://build.ros2.org/job/Rbin_uN64__performance_test__ubuntu_noble_amd64__binary/
So reverting rolling seems incorrect and it seems like you are very close to being able to build on the other platforms as it works in your CI and on the build farm.
| doc: | ||
| type: git | ||
| url: https://gitlab.com/ApexAI/performance_test.git | ||
| version: 1.2.1 |
There was a problem hiding this comment.
This version looks like it was pinned to a version but not updated with the new releases.
| @@ -3884,21 +3884,6 @@ repositories: | |||
| url: https://github.com/ros-perception/perception_pcl.git | |||
| version: foxy-devel | |||
| status: maintained | |||
| performance_test: | |||
There was a problem hiding this comment.
As @audrow mentioned please don't modify EOL distros. They do not have any builds running anymore and are more of just a snapshot of the old state for historical purposes. As being EOL we don't want to be maintaining them anymore.
| @@ -3072,21 +3072,6 @@ repositories: | |||
| url: https://github.com/ros-perception/perception_pcl.git | |||
| version: foxy-devel | |||
| status: maintained | |||
| performance_test: | |||
| tags: | ||
| release: release/jazzy/{package}/{version} | ||
| url: https://github.com/ros2-gbp/performance_test-release.git | ||
| version: 2.0.0-2 |
There was a problem hiding this comment.
This version is failing because some module has flagged the rosdistro as unsupported. It seems that this should be resolvable potentially something has a hardcoded list of compatible versions.
https://build.ros2.org/job/Jbin_uN64__performance_test__ubuntu_noble_amd64__binary/115/console
00:01:55.303 CMake Error at CMakeLists.txt:500 (message):
00:01:55.303 Unsupported ROS_DISTRO
00:01:55.303
00:01:55.303
|
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
github-actions
bot
added
the
stale
Closes #42458