Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html: java 8 minimum #316

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

index.html: java 8 minimum #316

wants to merge 1 commit into from

Conversation

eddies
Copy link

@eddies eddies commented Apr 5, 2019

Updates minimum Java version as of v1.13.0

I assert that this patch is my own work, and to simplify the licensing of the BFG Repo-Cleaner:

(choose 1 of these 2 options)

  • I assign the copyright on this contribution to Roberto Tyley
  • I disclaim copyright and thus place this contribution in the public domain

Updates minimum Java version as of v1.13.0
@eddies eddies changed the title Update index.html index.html: java 8 minimum Apr 5, 2019
Copy link
Owner

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javabrett
Copy link
Contributor

Duplicates #283 which also adds JDK clarification.

@eddies
Copy link
Author

eddies commented Apr 5, 2019

Duplicates #283 which also adds JDK clarification.

sort of. #283 references v1.12.9 which isn't available in Maven and also doesn't match the release notes for v1.13.0. Also, I don't think it's clearer to change JRE for JDK. The JDK is not required to run bfg, only a JRE.

@eddies eddies closed this Apr 5, 2019
@eddies eddies reopened this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants