Fix rescue_from with invalid response #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap `default_rescue_handler` with `method`
Regenerate Rubocop's todo
|
I took the opportunity to fix the last RSpec/AnyInstance cop. |
manueljacob
reviewed
Jul 23, 2024
spec/grape/api_spec.rb
Outdated
| @@ -2196,8 +2196,6 @@ def foo | |||
| it 'uses default_rescue_handler to handle invalid response from rescue_from' do | |||
There was a problem hiding this comment.
I suggest to change the name of the example to reflect that it doesn’t anymore test the implementation detail that it uses default_rescue_handler.
|
@manueljacob you good with this? |
manueljacob
reviewed
Jul 23, 2024
Co-authored-by: Manuel Jacob <[email protected]>
manueljacob
approved these changes
Jul 23, 2024
|
@ericproulx great job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2477
cc @manueljacob