Feat: Add statistics info for jsontests #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
approved these changes
Dec 6, 2023
aleksuss
reviewed
Dec 6, 2023
| for filename in fs::read_dir(filename)? { | ||
| let filepath = filename?.path(); | ||
| let filename = filepath.to_str().ok_or(Error::NonUtf8Filename)?; | ||
| run_file(filename, debug)?; | ||
| println!("RUM for: {filename}"); |
There was a problem hiding this comment.
Suggested change
| println!("RUM for: {filename}"); | |
| println!("RUN for: {filename}"); |
aleksuss
reviewed
Dec 6, 2023
| // Print total statistics info | ||
| pub fn print_total(&self) { | ||
| println!( | ||
| "\nTOTAL: {:?} tests\n\tCOMPLETED: {:?}\n\tSKIPPED: {:?}", |
There was a problem hiding this comment.
Suggested change
| "\nTOTAL: {:?} tests\n\tCOMPLETED: {:?}\n\tSKIPPED: {:?}", | |
| "\nTOTAL: {} tests\n\tCOMPLETED: {}\n\tSKIPPED: {}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
➡️ At the moment, when tests are run, the output results are uninformative and difficult to analyze. This PR adds minimal statistical information to the tests passed and changes the output to make it more convenient to analyze.
🌇 Changes
TestCompletionStatustype✅ Example output for a single test
✅ Example statistic info output