Supertrait item shadowing v2

[Amanieu]

This is an alternative to #2845 which aims to resolve the issues surrounding the stabilization of Iterator::intersperse.

Summary

When name resolution encounters an ambiguity between 2 trait methods, if one trait is a sub-trait of the other then select that method instead of reporting an ambiguity error.

Rendered

[fbstj]

nit:

Suggested change

	When name resolution encounters an ambiguity between 2 trait methods, if one trait is a sub-trait of the other then select that method instead of reporting an ambiguity error.
	When name resolution encounters an ambiguity between 2 trait methods, if one trait is a sub-trait of the other then select the sub-trait method instead of reporting an ambiguity error.

[lcdr]

I'd like to know how this would interact with the previous RFC #2845 . Is this meant as a complete replacement or as an extension? I deliberately did not address use declarations in that RFC as to keep the RFC simple, so in principle the RFCs are independent.

It reads as a replacement, but fundamentally the same issue also occurs with generic trait bounds, which I was trying to address in the previous RFC. What do you propose in the case where someone has written a generic bound for itertools::Itertools like fn foo<I: itertools::Itertools>(i: &I) ?

[Amanieu]

This is intended as a replacement for #2845 since it is more general: this RFC effectively proposes one of the alternatives listed in #2845 where we always prefer the sub-trait no matter what generic bounds are in use (and also applying to the more general case of use).

What do you propose in the case where someone has written a generic bound for itertools::Itertools like fn foo<I: itertools::Itertools>(i: &I) ?

This RFC would always resolve I::intersperse to Itertools::intersperse since it comes from a sub-trait.

[senekor]

Why is picking a different name not a reasonable path? The unavoidable bikeshedding around a new name is annoying, but it seems to me like a small, one-time cost compared to the permanent additional language complexity of this feature.

I also wonder how many times we anticipate to run into this problem in the future. Are there more examples aside from Itertools::intersperse? If we only ran into this problem once within 9 years of Rust being stable, the benefit of this feature seems very limited.

[ripytide]

Picking a new name also has disadvantages other than than the time taken to pick it, users then have to learn the new method name and that it is semantically identical to the Itertools::intersperse() yet has a different name. This is not a one-time cost as it will effect all future users when, for example, searching docs for this method. This would be the case for all methods stabilized from itertools to std which might be quite a few if we had a reliable way to do such a migration.

[senekor]

users then have to learn the new method name

I don't see the problem. People who are using intersperse from itertools shouldn't expect the standard library to use the exact same name. And I assume few people rely on the unstable version in std for production code, it would be unwise to opt into breaking changes for what amounts to a small ergonomics improvement (which a library can also provide).

For regular Rust users, the function doesn't exist right now. In the future it may - its name is an open question.

This would be the case for all methods stabilized from itertools to std which might be quite a few

I agree that this is something to consider, we don't want to have to pick the "second best" name for many functions in std. But first we should think concretely about which methods from itertools might actually make the jump into std. itertools has been around for a long time and I'm not aware of a big push to upstream many of its methods. Which indicates to me, there isn't that much need. But I'm happy to be convinced otherwise. Examples from other libraries besides itertools count as well.

[digama0]

The issue is that because itertools is used widely, std cannot upstream methods from itertools without causing lots of breakage in all crates currently using itertools. This is a perverse incentive which forces the "second best" issue you mentioned, and it's not limited to itertools, it happens whenever std lacks a function, someone implements an extension trait to add it in a crate (as they should), and everyone picks it up because it is really useful (as they should). The exact sequence of events which leads to strong evidence that something should be in std is also the sequence of events that blocks it from being added to std.

[senekor]

I understand that. The reason I'm pushing back is that to me, the feature doesn't seem to align with Rust's design principles. This new implicit default doesn't seem obviously correct to me. If I call a method that has two implementations, I would generally prefer the compiler yell at me rather than pick one without telling me. That's why I think we should be certain that we'll make good use of this feature before adding it.

But I'll admit this is a theoretical objection. In practice, the problem may never show up and then it's fine to add the feature. Pragmatism comes first. I guess I just agree with this comment. We should think about edge cases where this could go wrong.

[cynecx]

I would generally prefer the compiler yell at me rather than pick one without telling me

The rfc mentions this:

This behavior can be surprising: adding a method to a sub-trait can change which function is called in unrelated code. A lint could be emitted to warn users about the potential ambiguity.

[senekor]

Yeah, a lint would make sense if the migration-situation with intersperse is the only use case we expect this feature to be used in practice. But maybe some users will use the shadowing to implement a form of specialization? Or any other unrelated use case I can't think of right now. If that happens, it might lead to a discussion about whether the lint should be enabled by default or not. And if it ends up allow-by-default, it loses much of its value.

[ripytide]

How about an alternative approach for stabilization where itertools renames any methods that the standard library promises to stabilize, like Itertools::intersperse() to Itertools::it_intersperse(). Then after this is released for a reasonable amount of time such as 6/12/18/24 months we hope that a majority of the ecosystem has migrated to this new name. At which time we can stabilize that method on Iterator with mitigated ecosystem churn.

This way we don't have to add any language complexity, while still being able to migrate any methods we like, at the expense that it takes quite a while to do so.

[ripytide]

Then we could then add clippy lints for these renamed methods to encourage people to switch back to the stabilized std versions.

[ChayimFriedman2]

Instead of relying on trait dependence, maybe we can rely on crate dependence? That is, if one crate crate is a dependency of the other use its method.

[jhpratt]

(not directed at anyone in particular)

Keep in mind that this RFC is generally applicable, not specific to itertools. While it is the current impetus, it is a near certainty that this will cause issues in the future. Relying on the current "technically not breaking" is obviously insufficient, as otherwise intersperse would've already been stabilized.

[senekor]

It seems to me like we're adding a feature to the language not because we think it's a good feature on its own, but because it happens to have a convenient side effect for the work of the project. It feels wrong, but I'll always agree to go the pragmatic route.

I'll throw in another idea for an alternative: hard-code the method resolution for those exact methods we want to uplift into std. See a call to intersperse with Itertools in scope? Resolve to one or the other silently, because we know the semantics are identical. All other ambiguities still cause an error as is the status quo. Ugly? Yes. Pragmatic? Maybe.

The advantage I see would be that there is no seemingly useless "feature" in the langauge we have to support forever. There is no user-facing change. We may at some point run crater again and if use of Itertools::intersperse has dropped low enough (there could also be an active effort to migrate the ecosystem) we may finally remove the hard-coded method resolution. Smooth migration, no renaming necessary, no additional language complexity.

I have no idea how complex this would be in terms of the implementation. This is certainly not worth paying for with much complexity.

[burdges]

We should clarify the problematic scenario here:

We've a crate victim that imports say rand::Rng and attack_vactor::prelude::* for some other crate attack_vactor, so now adding a subtrait of Rand to attack_vactor::prelude::* changes beahvior of rand::Rng in victim. That's pretty bad.

There are several safer alternatives:

1. Add some #![auditable] attribute that disables all shadowing, except ideally you want shadowing disabled in both dependents and dependencies too.
2. Always choose the supertrait method, never the subtrait method, in this case meaning core::Iterator::intersperse not Itertools::intersperse. It's still problematic, but works assuming supertrait crates behave more carefully than subtrait traits.
3. Always choose the method from the trait defined under the later edition setting. At this point, itertools simply removes their intersperse method, so then an earlier edition itertools used with a later edition core results in core overriding itertools.
4. Always choose the supertrait method, but return an error unless the supertrait method has a shadow attribute that declares the editions being shadowed. Aka roughly 2+3+attribute.

trait Iterator<..> {
    ...
   #[shadow(edition < 2024)]
    fn intersperse(self, element: Self::Item) -> Intersperse<Self>;
}

I'd think 4 or similar provides the safest solution. We'd stabalize the shadow attribute so that ecosystem crates could benefit too, but only under edition upgrades.

[archer-321]

I'll throw in another idea for an alternative: hard-code the method resolution for those exact methods we want to uplift into std. See a call to intersperse with Itertools in scope? Resolve to one or the other silently, because we know the semantics are identical. All other ambiguities still cause an error as is the status quo. Ugly? Yes. Pragmatic? Maybe.

@senekor, I wonder whether the project would be OK with the implications this has for other (non-rustc) Rust compilers. If this hardcoded list defines method resolution, it would likely have to be mentioned in the reference, and the way I understand your suggestion, removing the hardcoded list would be a breaking change (e.g., because code that was working with the workaround while never being updated would stop working).

I agree that complex features like this must be considered carefully, especially if they can introduce unexpected results. However, hardcoding a list of workarounds for method resolution could easily be "just as confusing", IMHO.

[senekor]

the implications this has for other (non-rustc) Rust compilers. If this hardcoded list defines method resolution, it would likely have to be mentioned in the reference

Yes, that's a good point. It's not an impossible problem to solve, but I'm not fond of the idea myself.

adding a subtrait of Rand to attack_vactor::prelude::* changes beahvior of rand::Rng in victim

Thank you, that is the kind of situation I was worried about. Although this seems hard to exploit in practice, I think it shows that the language feature isn't very desirable on its own.

I like the idea of picking the supertrait method iff the supertrait opted into this shadowing behavior. It makes it clear that this feature is meant for our exact migration use case only. I'm not sure if gating on a specific edition and stabilization are necessary, it seems like those things could be added later as well, if they turn out to be needed.

[kennytm]

@burdges

"A lint could be emitted to warn users about the potential ambiguity."

So #![auditable] for the current crate is just #![deny(rfc_3624_lint)].

Perhaps there should also be another lint, that detects when the sub-trait defined that shared the exact same name with the super-trait, to address the "dependents" case.

---

BTW I'm very confused why some comments here keep saying this RFC is a "complex feature". The whole feature is literally described in 4 sentences. The implementation is most likely localized to the probe phase. There isn't much complexity added compared with many other RFCs out there.

[archer-321]

BTW I'm very confused why some comments here keep saying this RFC is a "complex feature". The whole feature is literally described in 4 sentences. The implementation is most likely localized to the probe phase. There isn't much complexity added compared with many other RFCs out there.

At least for my comment, "complex feature" means a feature introducing language complexity. Many RFCs have more complex implementation details, but this RFC can still be complex language-wise if it makes the code harder to understand. In this case, writing new code using the standard library implementation while old code continues to use the itertools implementation could make the same line of code lead to two different method implementations depending on a use statement in the module.

Some programming languages are centred around keeping language complexity to a minimum, even if it comes at the cost of convenience.

Now, Rust isn't Zig or Go, and the language complexity introduced by this feature is likely manageable, as this form of method resolution "feels natural" in most cases. As such, I personally don't think the complexity should block this RFC.
However, the potential increase in cognitive load should be discussed, IMO.

[senekor]

@kennytm I am also thinking about langauge complexity, specifically for people learning Rust. I recently taught a Rust workshop and traits were a difficult topic for the participants. I'm wondering if in the future, I'll have to teach people about which trait method will be implicitly selected under which circumstances.

Now, it's likely that the average Rust dev will never come into contact with this feature in the first place (meaning I don't have to teach it), because it only ever comes up in such migration situations. In that case, I'm perfectly fine with it. I'm just not sure of it yet. I'm trying to think of ways this feature could be (ab)used in ways that newcomers will have to know about. No success so far, which is a good sign.

What would be the downside of always resolving the implementation to the supertrait? For the intended use case, it doesn't matter, because they are the same. It's also closer to what we're trying to achieve in the first place: Move away from the subtrait toward the supertrait. It seems like less potential for spooky-action-at-a-distance to me. Adding or removing a use statement cannot modify the bahavior of the program. (Or can it already, for different reasons? I'm not sure.)

[programmerjake]

Adding or removing a use statement cannot modify the bahavior of the program. (Or can it already, for different reasons? I'm not sure.)

adding use statements can already change method resolution, e.g. here calling v.len() returns a String where v: Vec<u8>:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=549b192cbf93758ce85965bb442fc68d

[compiler-errors]

I know it's implicit in the statement of "encounters an ambiguity" (because having an ambiguity is dependent on actually having two methods in scope), but I would appreciate if the RFC mentions that we won't automatically select a subtrait method if it's not in scope.

In practice, for the Itertools example, this RFC's new rules only apply if we actually use itertools::Itertools so it's actually in scope (and therefore it's able to create an ambiguity at all).

[burdges]

I think "complexity" does not capture the concerns here, really neither does "intuitiveness". We do not need a single word that captures the concerns though.

Wow @programmerjake that's really nasty. Any idea why that happens? I'd thought inherent methods always won out in resolution? Can we lint against this behavior? Or does std require it somewhere?

Although this seems hard to exploit in practice, I think it shows that the language feature isn't very desirable on its own.

It's not "hard to exploit" in the same sense in which secureity people say "hard to exploit". It's quite easy. An exploit requires work of course, but that's common.

Accedental changes cause some concern too here, like when using traits at VM boundaries.

@kennytm Cool. Yeah, I figured some lint would appear eventually, but..

#![deny(rfc_3624_lint)] would protect your crate against dependencies, which makes it more useful than #![deny(unsafe_code)]. So #![deny(rfc_3624_lint)] would hopefully become more commonly used than #![deny(unsafe_code)].

As denying should become common, we should ask what solution really makes the most sense here?

Around my 3. Afaik, there is no good reason to favor the subtrait method over the supertrait here. It's clear either direction could break agreement between static methods and trait object methods, but we'd break agreement less if we favor supertraits over subtraits. Again, this does not solve the problem I mentioned either, but again it's less bad this way.

Around my 4. We want shadowing to remain rare, so op-in attributes should create less work than any op out solution. Yes, op-in is delicate too, but several designs make sense, so they should be seriously discussed. I thought up op-ins that exploit edition boundaries, but maybe other flavors make sense.

[cynecx]

Any idea why that happens? I'd thought inherent methods always won out in resolution? Can we lint against this behavior? Or does std require it somewhere?

That's probably because the method candidate fn len(self) doesn't require additional autoref-ing.

[burdges]

I'll single out the simplest seeming solution:

Add a #[subshadow] attribute which causes a supertrait item to shadow a subtrait iterm, but otherwise the name conflict causes an error like now. core::Iterator::intersperse would gain this attribute, thereby replacing Itertools::intersperse.

Implementation should be similar to this RFC, except the shadowing would be reversed, and turnned off by default.

Any errors must originate from the rare excplicit references to itertools::structs::Intersperse. We'd solve those by only stabalizing core::Iterator::intersperse in the next edition. If you use itertools struct explicitly, then you must upgrade itertools when you upgrade rust editions, so that your itertools reexports this from core.

There are no impacts on how you read or audit code here: We only have supertraits shadowing subtraits, which sounds safer, for both trait objects and supply chain attacks, but even this shadowing only occurs when explicitly required by the supertrait.

Am I missing anything?

[jhpratt]

Consider this situation:

• library A has trait Foo
• crate B, depending on A, has trait FooExt with Foo as a supertrait
• A adds a new method to Foo, but it has a default implementation so it's not breaking. B has a pre-existing method with the same name.

In this general case, the reason this cannot be resolved in favor of the supertrait is that the method signatures are not necessarily compatible.

In code:

#![allow(unused)]

mod a {
    pub trait Int {
        // fn call(&self) -> u32 {
        //     0
        // }
    }
    impl Int for () {}
}

mod b {
    pub trait Int: super::a::Int {
        fn call(&self) -> u8 {
            0
        }
    }
    impl Int for () {}
}

use a::Int as _;
use b::Int as _;

fn main() {
    let val = ().call();
    println!("{}", std::any::type_name_of_val(&val));
}

Resolving in favor of a is a breaking change; in favor of b is not. The only other option is the status quo: not compiling. a simply cannot happen lest we violate backwards compatibility and the status quo is not ideal. Personally I view b as the only sensible solution, and that is this RFC.

@burdges Nothing about this RFC is specific to the standard library, so I don't see how you envision an edition fitting into this.

[davidhewitt]

As far as I can tell, regardless of the outcome of this RFC, we still have to view introduction of trait methods as introducing ambiguity, e.g. for the intersperse case there might be some other trait method Bar::intersperse which does not have a relationship to either Iterator or Itertools. This RFC does not help with ambiguity in that case (and I don't think it should try to).

The main benefit I can see of this RFC is that it allows me as a library maintainer to refactor methods into supertaits without breaking explicit usage of SubTrait::method by UFCS. I can see that being useful from time to time.

I also think this RFC proposes an idea that feels consistent with both Deref shadowing and also #3245, so the additional complexity doesn't seem high.

[kennytm]

@archer-321 @senekor However, item shadowing is already happening with inherent vs trait methods, so that "complexity" already existed. (Not to mention the auto-ref based method resolution mentioned #3624 (comment) which was exploited for like Generalized Autoref-Based Specialization. This is the emergent complexity.).

Explaining this RFC is as simple as

For each step of auto-deref/auto-ref,
 1. Pick the inherent item `S::name` if it existed
 2. Find all traits `Tn` that `S` implements, and check every trait that `Tn::name` existed.
    If there is a single unique trait `T0` defining `T0::name`
-   and no other traits do,
+   which is a subtrait of every other traits that do,
    pick `T0::name`, otherwise (if there are >1 such candidates) fail for ambiguity error.

[burdges]

Nothing about this RFC is specific to the standard library,

Also in my proposal.

so I don't see how you envision an edition fitting into this

An edition change provides a flag that downstream code upgraded. There is no reason other code cannot use this flag independently of the standard library, but major version upgrades provide a similar flag.

In this general case, the reason this cannot be resolved in favor of the supertrait is that the method signatures are not necessarily compatible.

Sure.

We'd exploit the edition boundary in my proposal precisely because itertools has an incompatible method signature, since itertools' methods are not -> impl Iterator. It's mostly invisible of course since everyone infers the type usually. A transition not involving core could ignore such an invisible signature break, or wait for their own major version upgrade.

In general, subtraits being favored brings a similar problem too. We could build examples that this RFC breaks too: Initially a crate has both use core::iter::Intersperse and use foo::prelude::* which then breaks when foo add itertools into its prelude. We'd need itertools to gate their intersperse upon an edition boundary.

At a high level, all this seems extremely rare, so it's much worse to make auditing hard across the whole ecosystem.

If you ship this RFC as proposed, then supply chain attacks should eventually make #![deny(rfc_3624_lint)] commonplace. That'd completely break the feature this RFC proposes. At that point, you're then stuck favoring subtraits, so you cannot adopt more workable alternative like I'm proposing.

In fact, we'll definitely have future legislation about supply chain attacks in many jurisdictions, especially for government contractors. It's likely legislation cares about upgrades, but does not care about build breakage, which could make #![deny(rfc_3624_lint)] very appealing.

[senekor]

Thanks for the explanations all, my opposition to this is dwindling.

I agree with @burdges proposal to make this behavior opt-in from the supertrait side. So far, there hasn't been a use case discussed where it would be desirable for this shadowing to happen without the knowledge / consent of the supertrait author. So I don't see a reason to extend this implicit behavior beyond its intended use case.

[Amanieu]

• Always choose the supertrait method, never the subtrait method, in this case meaning core::Iterator::intersperse not Itertools::intersperse. It's still problematic, but works assuming supertrait crates behave more carefully than subtrait traits.

In the Iterator case we actually want to prefer the subtrait method because it may have a different signature than the one in the supertrait. Consider the Iterator case, if we prefer supertrait methods then it forces the standard library version to always have the exact same signature as the Itertools version. We want to keep the flexibility of making API changes when uplifting functions to the standard library.

• Always choose the method from the trait defined under the later edition setting. At this point, itertools simply removes their intersperse method, so then an earlier edition itertools used with a later edition core results in core overriding itertools.

This would mean that Iterator can only be changed on edition boundaries every 3 years. This would severely slow down the development of the standard library, which is unacceptable.

• Always choose the supertrait method, but return an error unless the supertrait method has a shadow attribute that declares the editions being shadowed. Aka roughly 2+3+attribute.

An attribute could be an interesting idea, but in a different way: we could explicitly mark specific methods on the Iterator trait so that the logic proposed in this RFC would only apply to these methods. However if this is the case then it is unlikely that this attribute will ever be stabilized: it will remain as a hack just to support the evolution of the Iterator trait in the standard library.

[nikomatsakis]

@rfcbot concern lint

The other question is whether to have a "warn by default" (or perhaps "deny by default") lint for this kind of shadowing. I think we should. We can always make it allow later if we decide, but I am convinced by this comment from @burdges as well as the concerns by @senekor here:

It risks supply chain attacks, which shall only worsen in future

Basically it seems clear that this feature will create more room for confusion and isn't a pattern we want to exactly encourage. We are looking to address the "migrate code upstream" pattern specifically, in which case I expect a warning is appropriate (though I also expect downstream may come to deprecate the method in question).

I do want to say though that we already have room for quite some clever hacks when it comes to method dispatch, though, so I'm not overly worried.

[nikomatsakis]

Oh, I see a disposition merge had already begun! In that case,

@rfcbot reviewed

[burdges]

Yes, default warn makes sense, so then anyone using Itertools::intersperse must opt-in, until itertools removes intersperse in some future major version.

It's also less bad overall if the shadowed trait must opt-in to being shadowed by downstream crates. It's possible then only Iterator would be shadowed much in practice, but even here crates should deny this behavior, preferably throughout their dependency tree. It's even possible to supress this behavior when doing glob imports.

---

Also, do the specilization concerns appear here?

trait Bad1 {
    fn bad(&self);
}

impl<T> Bad1 for T {
   fn bad(&self) {
        println!("generic");
    }
}

trait Bad2 : Bad1 {
    fn bad(&self);
}

impl<T: 'static> Bad2 for T {
    fn bad(&self) {
        println!("specialized");
    }
}

fn main() {
    "test".bad()
}

It's simply picking the applicable trait before trans I guess? Any "feels wrong" arguments against specilization apply here, but no soundness breaks, right?

[kennytm]

Yes, default warn makes sense, so then anyone using Itertools::intersperse must opt-in, until itertools removes intersperse in some future major version.

🤔 Removing intersperse is a breaking change. Not a good reason to publish a new major version just to silence a lint (even if itertools is 0.13.0 right now).

Is it possible for the subtrait to reduce its priority if the item is marked #[deprecated]?

[traviscross]

The other question is whether to have a "warn by default" (or perhaps "deny by default") lint for this kind of shadowing.

@Amanieu: To what degree would libs-api be willing to do these uplifts if they would result in significant warnings across the ecosystem?

I recall in the discussion about linting against imports made redundant by a glob import that someone from libs-api mentioned that, if adding something to the prelude would provoke a significant number of warnings in the ecosystem due to this, that libs-api would need to treat it as something almost like a breaking change.

How true or not true would that be here for these kind of uplifts?

[Amanieu]

I'm adding a concern just to add a note to the RFC, @Amanieu, that includes an example like this and specifies that we will continue to get an error for ambiguity:

Today that example will give an ambiguity error. With this RFC, it will instead always resolve to the sub-trait method and then compilation will fail because Vec does not implement the Copy trait required by Bar::method.

I will add it to the RFC as an example.

Is it possible for the subtrait to reduce its priority if the item is marked #[deprecated]?

We specifically don't want to do this because the standard library's signature may be different from the one in itertools. In fact, this is already the case for the proposed Iterator::contains. Itertools would not be able to remove their method without breaking current users.

The other question is whether to have a "warn by default" (or perhaps "deny by default") lint for this kind of shadowing. I think we should.

I'm inclined to agree. The lint should give 2 separate suggestions that the user can use to resolve the ambiguity:

• If you want to use the Iterator version then you should use Iterator::contains(iter, item).
• If you want to use the Itertools version then you should use Itertools::contains(iter, item).

[kennytm]

I'm inclined to agree. The lint should give 2 separate suggestions that the user can use to resolve the ambiguity:

• If you want to use the Iterator version then you should use Iterator::contains(iter, item).
• If you want to use the Itertools version then you should use Itertools::contains(iter, item).

If the lint is deny-by-default there is no advantage accepting this RFC vs the current situation.

error[E0034]: multiple applicable items in scope
 --> src/lib.rs:8:24
  |
8 |     "1,2,3".split(",").intersperse("|")
  |                        ^^^^^^^^^^^ multiple `intersperse` found
  |
  = note: candidate #1 is defined in an impl of the trait `Itertools` for the type `T`
  = note: candidate #2 is defined in an impl of the trait `Iterator` for the type `std::str::Split<'a, P>`
help: disambiguate the method for candidate #1
  |
8 |     Itertools::intersperse("1,2,3".split(","), "|")
  |
help: disambiguate the method for candidate #2
  |
8 |     Iterator::intersperse("1,2,3".split(","), "|")
  |

[Amanieu]

@Amanieu: To what degree would libs-api be willing to do these uplifts if they would result in significant warnings across the ecosystem?

I recall in the discussion about linting against imports made redundant by a glob import that someone from libs-api mentioned that, if adding something to the prelude would provoke a significant number of warnings in the ecosystem due to this, that libs-api would need to treat it as something almost like a breaking change.

How true or not true would that be here for these kind of uplifts?

In the end, it's all about the volume of warnings. Fundamentally, a new warning is not a breaking change. It may cause a few crates to start failing CI if they deny warnings (which is common).

The reason we were hesitant about prelude updates is that prelude candidates are likely to be widely used in the ecosystem. If the lint was kept, it would mean that a large portion of the crate ecosystem that denies warnings in CI gets broken. Again, this isn't a breaking change, but it would result in a lot of churn to fix all affected crates.

I don't think the warning proposed here is going to affect many crates, only the ones that specifically use Itertools::contains and deny warnings in CI. So I would consider this acceptable here.

[burdges]

As asked above, how do the specilization-like conflicts resolve? In particular if the subtrait were restricted by lifetime.

[Amanieu]

As asked above, how do the specilization-like conflicts resolve? In particular if the subtrait were restricted by lifetime.

I think that's mostly explained by the example I added? Name resolution happens before trait solving so it will ignore trait bounds. This means that in your example Bad2::bad will always be selected.

[tmandry]

We'll be creating a slightly bad experience for users of itertools with the lint, and that will only be resolved by the crate releasing a new semver-incompatible version or a new trait (or perhaps doing rustc version hacks, if the signatures are compatible). That said, disambiguating with UFCS isn't so bad. On a related note: I'd like to see iter.Itertools::intersperse(a), which would be a nicer way of disambiguating, work in the future.

Anyway, it clearly seems worth it to stabilize intersperse in std and to mitigate supply chain attacks. I do see a future where we mitigate supply chain attacks in some other way and move the lint to the definition site of the subtrait. Or, less likely, decide silent shadowing isn't so bad after all and remove it entirely.

@rfcbot reviewed

[traviscross]

// @rfcbot reviewed (no-op here)

I agree with everything @tmandry said.

[compiler-errors]

Name resolution is not where method selection is performed. Method resolution is performed during typechecking.

I think the conclusion is still correct, though, and I would expect after implementing supertrait method shadowing that the code sample would give a Copy trait error, but that has more to do with the order dependence of method selection and type inference.

For reference, notice that this code works today:

trait Foo { fn method(&self) {} }
trait Bar: Foo { fn method(&self) {} }
impl<T> Foo for Vec<T> { }
impl<T: Copy> Bar for Vec<T> { }

fn main() {
    let mut x: Vec<Box<i32>> = vec![];
    // We disqualify `Bar`'s method since we know at this point
    // that `Vec<Box<i32>>` doesn't implement `Bar`, since
    // `Box<T>: !Copy`. Thus, there is no ambiguity.
    x.method();
    x.push(Box::new(22));
}

[compiler-errors]

I would prefer if we call this "method selection" or "method resolution", here and all other instances below. There's a pretty big difference between name resolution (which is performed pre-type-check) and method resolution (which is performed during typeck).

[nikomatsakis]

@rfcbot resolve discuss-ambiguity-and-inference

Notes: The RFC does not do the behavior I proposed and, as described and implemented by @compiler-errors, can prematurely commit to using a subtrait that winds up being inapplicable. I'm not crazy about this, but it's already true of method probing, and it seems potentially to be erring on the side of "caution", since we believe that subtrait methods are the ones that users are more likely to want (that is indeed the whole premise of this RFC). Also, @compiler-errors convinced me that ambiguity could arise very frequently in practice due to T: Sized bounds in particular.

To be quite honest, this kind of fine-grained interactions with inference are not (to me) things that RFC should specify. I consider that more the purview of the types team and something to be resolved at implementation-specification-and-stabilization time.

[nikomatsakis]

@rfcbot resolve lint

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[jswrenn]

We'll be creating a slightly bad experience for users of itertools with the lint, and that will only be resolved by the crate releasing a new semver-incompatible version or a new trait (or perhaps doing rustc version hacks, if the signatures are compatible).

This is going to create a slightly bad experience for the maintainers of itertools, too. We will get issues filed by users who would like us to remove now-shadowing methods for their toolchain because of the lint. (If we're very unlucky, those users will have also discovered that the rationale for the lint is to avoid supply chain attacks.) We won't be able to readily remove these methods, because that conflicts with our longstanding policy of maintaining a conservative MSRV. The only way we'll be able to reconcile these interests is by using build.rs-rustc-version-detection hacks, something we've intentionally avoided because build.rs is a vector for supply chain attacks.

Please consider making this lint allow-by-default.

[traviscross]

@rustbot labels +I-lang-nominated

Let's nominate to discuss the useful feedback from @jswrenn above.

(We can of course handle the setting of the lint level during stabilization, but we might as well discuss this while it's fresh.)

[kennytm]

We won't be able to readily remove these methods, because that conflicts with our longstanding policy of maintaining a conservative MSRV. The only way we'll be able to reconcile these interests is by using build.rs-rustc-version-detection hacks, something we've intentionally avoided because build.rs is a vector for supply chain attacks.

I think in the distant future you could use #[cfg(not(version("1.999")))] or #[cfg(not(accessible(::std::iter::Iterator::intersperse)))] to remove these methods, no need to invoke build.rs.

However I don't think rust-lang/rust#64796 nor rust-lang/rust#64797 is going to stabilize before this RFC or Iterator::intersperse, and a conservative MSRV policy probably means cfg_version/cfg_accessible can't be used at all.