Improve Bundler setup to support RVM aliases #52
Conversation
Without this change, the Bundler installation introduced by rvm#40 and rvm#41 fails when the `rvm_rubies` list contains valid RVM aliases, like following examples: - ruby-1.9.3 (→ ruby-1.9.3-p551) - ruby-2.0 (→ ruby-2.0.0-p643) - 2.1 (→ ruby-2.1.5) - ruby (→ ruby-2.2.0) - jruby (→ jruby-1.7.18) - etc. Add more test coverage to `.travis.yml`.
The (docker) container-based is default for any new github repository, and will be applied backward over time. It is thus safer to opt into the (openvz) virtualized environment. See http://blog.travis-ci.com/2015-03-31-docker-default-on-the-way/
|
Just noticed that this PR will conflict with #48. No problem for me to integrate this change as well, or rebase if necessary. |
|
@gildegoma Sorry for the late reply but are you thinking to rebase this PR |
|
@gildegoma would you mind rebasing this PR? |
|
@pkuczynski Sure, I'll do. (Sorry to have missed the previous call, but I wasn't using this role for quite a while...). |
|
No worries. Thanks for looking into it now :) Let me know when it's ready for the review... |
|
FYI: @pkuczynski I am waiting for #215 (which fixes the Travis CI setup, and extend the tests so it will be convenient to cover the change proposed here). |
|
@gildegoma seems that this has conflicts. Can you solve them? |
|
@pkuczynski this seems to conflict with #235, maybe we should prioritise review/merge of #235 so that the rest can be adapted? |
|
#235 is merged... @gildegoma can you rebase? |
Without this change, the Bundler setup fails when the
rvm_rubieslist contains valid RVM aliases, likefollowing examples:
These aliases are quite useful to refer to the latest release of a specific Ruby branch.