Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selection to another page #1085

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

QubaB
Copy link
Contributor

@QubaB QubaB commented Dec 31, 2023

Implemented moving selection across pages. Undo/redo works.

In Select added pageIndexStart holding original page of selection.
In EditorHistory added pageIndexStart - important only for move
In Editor is mainly change onDrawUpdate which should handle moving items to another page.

Closes #932

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: Patch coverage is 8.23529% with 78 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (64899f8) to head (3350fc4).

Current head 3350fc4 differs from pull request most recent head ce101ee

Please upload reports for the commit ce101ee to get more accurate results.

Files Patch % Lines
lib/pages/editor/editor.dart 6.09% 77 Missing ⚠️
lib/data/tools/select.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   35.95%   37.07%   +1.12%     
==========================================
  Files         115      110       -5     
  Lines        9076     8675     -401     
==========================================
- Hits         3263     3216      -47     
+ Misses       5813     5459     -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Undo/redo is not handled correctly because old items are deleted and new created.
In Select  added pageIndexStart holding original page of selection.
In EditorHistory added pageIndexStart - important only for move

Solving issue saber-notes#932
…selection movement is stored to history.

This fixes problem when selection is moved across pages, and then moved on page (in this case pageIndexStart was set according to the first movement of selection)
@CommanderRedYT
Copy link

What is the status here? What is blocking this MR?

@QubaB
Copy link
Contributor Author

QubaB commented Jun 19, 2024

I hope that from my side is all done.

@jaklt
Copy link

jaklt commented Jun 19, 2024

Thank you for coming back to this, I'm also patiently waiting for this to get resolved.

From what I understand, the status of this Pull Request is "This branch has conflicts that must be resolved". Maybe there are conflicting changes with the current state of the main branch?

@QubaB
Copy link
Contributor Author

QubaB commented Jun 19, 2024

Thank you for coming back to this, I'm also patiently waiting for this to get resolved.

From what I understand, the status of this Pull Request is "This branch has conflicts that must be resolved". Maybe there are conflicting changes with the current state of the main branch?

Yes, but this conflict can resolve only person with write access to repository, and I have no write access.

@QubaB
Copy link
Contributor Author

QubaB commented Jun 19, 2024

I tried to solve problem but one of the tests did not passed. @adil192, can you resolve it please. I have no idea how to improve my pull request more.

@CommanderRedYT
Copy link

@QubaB I am not sure about the rebase, there seems to be quite a huge amount of changes (many more files than before), I am not sure if this is intended.

@QubaB
Copy link
Contributor Author

QubaB commented Jun 19, 2024

I merged current main to my branch to be able to handle problem with commit in editor.dart (editor.dart was improved since Dec 2023). I am not familiar too much with merging branches. I hope @adil192 can manage it somehow.

@IsotoxalDev
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot drag selection to another page
5 participants