Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add better support for stylus hovering #1355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

3akev
Copy link

@3akev 3akev commented Sep 19, 2024

This PR adds handlers for hovering stylus events, which are used to switch to the eraser tool when the stylus button is pressed while hovering.

This replaces the old functionality where pressing the stylus button mid-stroke removes the stroke, making it more in-line with other note applications and (in my opinion) more user friendly.

Closes #859

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (94c176f) to head (9f1f9ac).

Files with missing lines Patch % Lines
lib/pages/editor/editor.dart 30.00% 7 Missing ⚠️
lib/components/canvas/canvas_gesture_detector.dart 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   47.22%   47.19%   -0.03%     
==========================================
  Files         116      116              
  Lines        9218     9229      +11     
==========================================
+ Hits         4353     4356       +3     
- Misses       4865     4873       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pen buttons on Android
1 participant