Patch reset cavern sg on new stage start #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hgmaure if you don't mind reviewing the changes in this PR since you found the bug, I'd appreciate it! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 86.21% 86.01% -0.21%
==========================================
Files 8 8
Lines 2010 1995 -15
==========================================
- Hits 1733 1716 -17
- Misses 277 279 +2
|
Signed-off-by: David Hart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial release of sansmic is supposed to mimic exactly the behavior of the old SANSMIC program. The sansmic code was set up to match the behavior stated in the SANSMIC documentation; the old documentation did not, however, match the actual behavior of the code. This patch returns the code to mimic the behavior of SANSMIC, and issues a warning that this behavior will be changed in the next release.