Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WJ-99] [WJ-323] Add code and HTML blocks in output #14

Merged
merged 16 commits into from
May 6, 2024

Conversation

emmiegit
Copy link
Member

@emmiegit emmiegit commented May 5, 2024

Exposes code and html block data in the output for the renderer. Also adds a name argument to [[code]] to allow for named code blocks, e.g. /code/foo.

@emmiegit emmiegit self-assigned this May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 76.83%. Comparing base (97d71ea) to head (b68e000).
Report is 3 commits behind head on main.

❗ Current head b68e000 differs from pull request most recent head 3d4b400. Consider uploading reports for the commit 3d4b400 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   76.77%   76.83%   +0.06%     
==========================================
  Files         209      210       +1     
  Lines        5516     5561      +45     
==========================================
+ Hits         4235     4273      +38     
- Misses       1281     1288       +7     
Flag Coverage Δ
ftml 76.83% <85.41%> (+0.06%) ⬆️
Files Coverage Δ
src/includes/parse.rs 91.89% <ø> (ø)
src/parsing/error.rs 52.17% <ø> (ø)
src/parsing/mod.rs 90.90% <100.00%> (+0.76%) ⬆️
src/parsing/rule/impls/block/blocks/html.rs 100.00% <100.00%> (ø)
src/parsing/token/mod.rs 86.66% <ø> (ø)
src/render/null.rs 100.00% <ø> (ø)
src/tree/mod.rs 100.00% <100.00%> (ø)
src/parsing/parser.rs 89.57% <94.73%> (+0.51%) ⬆️
src/parsing/rule/impls/block/blocks/code.rs 94.44% <90.00%> (-5.56%) ⬇️
...arsing/rule/impls/block/blocks/include_elements.rs 74.00% <66.66%> (-1.00%) ⬇️
... and 1 more

@emmiegit
Copy link
Member Author

emmiegit commented May 6, 2024

thanks @Yossipossi1

@emmiegit emmiegit merged commit 89c138d into main May 6, 2024
6 checks passed
@emmiegit emmiegit deleted the WJ-99-html-output branch May 6, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants