Add redaction character font #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the font contains only a single codepoint, it'd probably make sense to set |
|
@leo60228 TIL, 10/10 suggestion |
|
LGTM but I'm hesitant to officially approve because of my limited CSS experience |
emmiegit
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the fonts in sigma.css provide a FULL BLOCK character, causing it to fall back to browser default. On some systems (Fedora and Android at least), this default character is square, which breaks immersion by making redacted text look like it's about twice as long as it actually is:
4-digit SCP number:
This PR addresses this by adding a from-scratch font that provides a FULL BLOCK character with roughly the same dimensions as
0from Inter. Font is licensed SIL OFL and the copyright is attributed to The SCP Wiki.I have tweaked the top/bottom borders of the character to better align aesthetically with surrounding text, and the left/right borders extend slightly beyond the character's width to cover subpixel lines that are sometimes visible between adjacent characters.
It's not a variable font, I don't know how to do that. A future improvement could make it act similarly to Inter's variables.
Demo on https://scp-sandbox-3.wikidot.com/croquemtest revision 1501