Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontstack addition #109

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fontstack addition #109

merged 2 commits into from
Aug 21, 2024

Conversation

SYwaves
Copy link
Contributor

@SYwaves SYwaves commented Aug 15, 2024

Add Inter as a non-variable font fallback/Alias for system installed font; and Times New Roman as a preferred fallback on sidebar button for iOS devices.

Copy link
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leo60228
Copy link
Member

CSS Fonts Module Level 4 adds a ui-sans-serif generic font family which ideally could be used instead of this complex font stack, but it's currently only implemented by Safari.

The older system-ui seems like it could work instead, but on Windows it varies by locale and can resolve to a serif font in some cases.

@SYwaves
Copy link
Contributor Author

SYwaves commented Aug 21, 2024

even with system-ui or ui-sans-serif, a complete fallback fontstack would still be preferred.

@SYwaves SYwaves merged commit b777147 into main Aug 21, 2024
2 checks passed
@SYwaves SYwaves deleted the fontstack-change branch August 21, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants