build: enable Seastar to build shared and static libs in a single build #2427
+115
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
seastar-shared-static
branch
5 times, most recently
from
cea6dbc
to
0508fb3
Compare
|
@denesb could you please help review this change? it implements the proposal at scylladb/scylladb#2717 (comment) |
denesb
approved these changes
Sep 12, 2024
|
thank your Botond, for your generous review. |
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
before this change, we respect the CMake variable named `BUILD_SHARED_LIBS`, and build shared libraries if it is set, build static libraries otherwise. but this model cannot fulfill the needs of a parent project which needs to build both static and shared seastar libraries with different configuration in a multi-config generator settings. as `BUILD_SHARED_LIBS` is a CMake variable which cannot be changed at build time, and hence cannot be assigned with different values using generator expression. so, in this change, we add two options - Seastar_BUILD_STATIC_LIBS - Seastar_BUILD_SHARED_LIBS to configure if the build should generated static libraries and shared libraries respectively. but `BUILD_SHARED_LIBS` is still supported, and the behavior is backward compatible. the only user-visible differences are, the libraries of - seastar - seastar_testing - seastar_perf_testing are now aliases of the targets which builds the static or shared libraries. so one cannot build "seastar" as a target anymore, but should specify which library to build: ``` $ cmake --build build --target seastar # does not work anymore $ cmake --build build --target seastar-static $ cmake --build build --target seastar-shared ``` the reason is the limit of an ALIAS library, which cannot be used as a target. but we still need to use a non-interface library to generate .pc file, where, for instance, we use `$<TARGET_FILE_NAME:seastar_testing>` for the library list of a certain Seastar library. but a CMake-based project including seastar can still link against it using "seastar" as a library. Refs scylladb/scylladb#2717 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
seastar-shared-static
branch
from
0508fb3
to
da15e0c
Compare
|
v2:
|
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, we respect the CMake variable named
BUILD_SHARED_LIBS, and build shared libraries if it is set, build static libraries otherwise. but this model cannot fulfill the needs of a parent project which needs to build both static and shared seastar libraries with different configuration in a multi-config generator settings. asBUILD_SHARED_LIBSis a CMake variable which cannot be changed at build time, and hence cannot be assigned with different values using generator expression.so, in this change, we add two options
to configure if the build should generated static libraries and shared libraries respectively. but
BUILD_SHARED_LIBSis still supported, and the behavior is backward compatible. the only user-visible differences are, the libraries ofare now aliases of the targets which builds the static or shared libraries. so one cannot build "seastar" as a target anymore, but should specify which library to build:
the reason is the limit of an ALIAS library, which cannot be used as a target. but we still need to use a non-interface library to generate .pc file, where, for instance, we use
$<TARGET_FILE_NAME:seastar_testing>for the library list of a certain Seastar library.but a CMake-based project including seastar can still link against it using "seastar" as a library.
Refs scylladb/scylladb#2717
Signed-off-by: Kefu Chai [email protected]