Add add-on detection for premium metrics #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
requested review from
fealho,
frances-h and
a team
and removed request for
a team
amontanez24
commented
Jul 20, 2023
| @@ -6,11 +6,16 @@ | |||
| __email__ = '[email protected]' | |||
| __version__ = '0.10.2.dev0' | |||
|
|
|||
| import sys | |||
| import warnings as python_warnings | |||
There was a problem hiding this comment.
I had to do this because in the test when importing sdmetrics, warnings was being overridden by sdmetrics.warnings
frances-h
approved these changes
Jul 20, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 76.82% 77.04% +0.22%
==========================================
Files 84 83 -1
Lines 3309 3342 +33
==========================================
+ Hits 2542 2575 +33
Misses 767 767
☔ View full report in Codecov by Sentry. |
fealho
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #388