-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for gride size and position #250
Open
l-monnier
wants to merge
20
commits into
sebastiaanvisser:master
Choose a base branch
from
l-monnier:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft to support the following CSS properties: grid-row-start, grid-row-end, grid-column-start, grid-column-end, grid-row, grid-column and grid-area.
Add a `4` at the end of such data types and functions for more consistency.
This avoids a warning from the compiler.
Use of folding headings to make the documentation more compact.
Added a Example heading. There is unfortunately a bug with Haddock when trying to make the heading foldable.
This will allow a more finer control grain over the types and there documentation.
The checks are for the moment only when the custom-ident is created as a 'CustomIdent' type.
As long as there are no function implementing Either instead of the partial functions, there is a risk for invalid value being built by the user. Also we could later change the interface of those functions/constructors so they return an Either value.
Errors are now raised when invalid custom-ident are provided, regardless if they are provided as a String or as a CustomIdentGrid.
The compilation error is with older version of GHC when compiling with Nix.
Comments of arguments where not properly formatted and lead to a compilation failure for older version of GHC when testing the build with Nix.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Following our discussions in issue 176, here is my pull request for Grid size and position support.
I've also performed some minor corrections to avoid GHC compiler warnings and compilation failures with older version of GHC.
Some notes:
Let me know your thoughts.