Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(integration): properly waited for the image pull to complete #637

Merged
merged 1 commit into from
Jun 20, 2023
Merged

test(integration): properly waited for the image pull to complete #637

merged 1 commit into from
Jun 20, 2023

Conversation

travi
Copy link
Member

@travi travi commented Jun 20, 2023 •
edited
Loading

this uses the technique for waiting for the pull to complete from the dockerode readme and gets rid of our dependence on get-stream

@travi travi requested a review from gr2m June 20, 2023 03:48
gr2m
gr2m approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are a hero. Thank you. 🙇🏼

@gr2m gr2m merged commit 9b5d4ae into master Jun 20, 2023
4 checks passed
@gr2m gr2m deleted the docker-pull branch June 20, 2023 19:47
@github-actions
Copy link

🎉 This PR is included in version 10.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travi @gr2m