Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace read-pkg with read-package-json-fast #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mehulkar
Copy link

@mehulkar mehulkar commented Jan 31, 2024

The explanation of this PR is given in an "ecosystem cleanup" effort. My role is to do the grunt work to make progress on this effort, so my understanding of each task is minimal for this first pass. If there are concerns about merging this, I am happy to dig in further and make a stronger case!

@mehulkar
Copy link
Author

@travi would you be able to help shepherd this in?

@@ -55,5 +55,5 @@ test("Throw error if package.json is malformed", async (t) => {
errors: [error],
} = await t.throwsAsync(getPkg({}, { cwd }));

t.is(error.name, "JSONError");
t.is(error.name, "JSONParseError");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could technically be seen as a breaking change1. The underlying libraries just use different error classes.

Footnotes

  1. considering this is a semantic-release library, I'm guessing the change is breaking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant