Fixes Error "Request Entity Too Large" #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
|
tested on local successfully, will test on dev now |
Signed-off-by: munishchouhan <[email protected]>
|
Tested successfully in dev: |
Signed-off-by: munishchouhan <[email protected]>
pditommaso
requested changes
Aug 1, 2024
| * Truncate the payload if it exceeds the maximum size | ||
| */ | ||
| protected static truncateLargeCondaFile(String condafile) { | ||
| int maxSize = 14 * 1024 //14 KB for the file and 2 KB for the rest of the fields |
There was a problem hiding this comment.
let's make a config option for this as usual
src/main/groovy/io/seqera/wave/service/persistence/impl/SurrealPersistenceService.groovy
Outdated
Show resolved
Hide resolved
| @@ -95,6 +95,7 @@ class SurrealPersistenceService implements PersistenceService { | |||
|
|
|||
| @Override | |||
| void saveBuild(WaveBuildRecord build) { | |||
| build.condaFile = truncateLargeCondaFile(build.condaFile) | |||
There was a problem hiding this comment.
Think can also happen for the docker file in principle
There was a problem hiding this comment.
ok will add it too
I think when condafile is present continerfile will be our template so it wont exceed size, but when we only have dockerfile, size can be bigger
…lPersistenceService.groovy Co-authored-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Aug 1, 2024
src/main/groovy/io/seqera/wave/service/persistence/WaveContainerRecord.groovy
Show resolved
Hide resolved
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
|
Surreal have exposed config variables to modify HTTP request size limit It will be released in v 2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a method to truncate condafile to 14kb if it is bigger than that