EC Hash Edits #80
Open
EC Hash Edits #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,14 +125,18 @@ class MathSwipeController | |||
| generateBoard: (inputs, length, solutionPlacements) -> | |||
| DFS.setEquationsOnGrid length, inputs, AdjacentCellsCalculator, solutionPlacements | |||
|
|
|||
| generateInputs: (inputLengths, inputs, goals) -> | |||
| generateInputs: (inputLengths, goals = [], inputs = []) -> | |||
There was a problem hiding this comment.
I'd rather have goals = [], inputs = [] as the first two lines of the method since you're only calling @generateInputs using the inputLengths
bmwwoo
force-pushed
the
ec-hash-edits
branch
4 times, most recently
from
5ab5d01
to
1990098
Compare
bmwwoo
force-pushed
the
ec-hash-edits
branch
from
1990098
to
251c0b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @chuj, @bmwwoo, @s-gogna
Here are some changes to the code organization of the branch. It cleans up some ambiguous code and uses some nice coffee tricks to make some of the logic clearer.
Let me know what you think.
Also, I didn't make all of the changes I think are necessary. This still needs work (e.g. the duplicated code that was in
ShareGameServiceand is moved toHashingService). I think this is a step in the right direction though.