Additional PBR textures, metallic/roughness texture + tangents

[mrehayden1]

No description provided.

[mrehayden1]

The tests in test/Text.GLTF.LoaderSpec.hs are still failing. Could use your help with these as I don't have access to the original blender project / whatever you used to generate the .glb/.gltf files.

[sgillespie]

I don't have access to the original blender project / whatever you used to generate the .glb/.gltf files.

Sorry, haven't had a chance to look yet, but these are basically just the blender default starter project with a cube. You could import the gltf files into blender and look at the differences.

[sgillespie]

This seems to make the tests pass:

diff --git i/test/Text/GLTF/LoaderSpec.hs w/test/Text/GLTF/LoaderSpec.hs
index 1aef6a8..1ee83b7 100644
--- i/test/Text/GLTF/LoaderSpec.hs
+++ w/test/Text/GLTF/LoaderSpec.hs
@@ -84,7 +84,10 @@ expectedMaterials =
         materialAlphaMode = Opaque,
         materialDoubleSided = True,
         materialEmissiveFactor = V3 0.0 0.0 0.0,
+        materialEmissiveTexture = Nothing,
         materialName = Just "Material",
+        materialNormalTexture = Nothing,
+        materialOcclusionTexture = Nothing,
         materialPbrMetallicRoughness =
           Just
             $ PbrMetallicRoughness
@@ -96,7 +99,8 @@ expectedMaterials =
                         textureTexCoord = 0
                       },
                 pbrMetallicFactor = 0.0,
-                pbrRoughnessFactor = 0.5
+                pbrRoughnessFactor = 0.5,
+                pbrMetallicRoughnessTexture = Nothing
               }
       }
   ]
@@ -198,6 +202,7 @@ expectedMeshes =
                     V3 0.0 (-1.0) (-0.0),
                     V3 0.0 0.0 1.0
                   ],
+                meshPrimitiveTangents = [],
                 meshPrimitiveTexCoords =
                   [ V2 0.625 0.5,
                     V2 0.625 0.5,

I'm still considering how far I want to take these test files generated from blender. On the one hand it's nice to verify we can actually parse an exported project, but on the other I'm not sure how much more this will scale.

[mrehayden1]

Automated tests are great and all, but I find the cost of maintaining them to be quite high.

Is there possibly a way we could use quickcheck?

I'm quite happy to e2e test the features while they're relevant to me otherwise, maybe you could release pre-release versions for testing bleeding edge features with?

[sgillespie]

Is there possibly a way we could use quickcheck?

I would love to use property tests, but I haven't been able to wrap my head around how I could do this with https://hackage.haskell.org/package/gltf-codec.

[sgillespie]

Automated tests are great and all, but I find the cost of maintaining them to be quite high.

As I said before, I'm not sure I like the Blender tests test/Text/GLTF/LoaderSpec.hs. I'm inclined to keep them as simple as possible, and rely on the unit tests (test/Text/GLTF/Loader/Internal/*.hs) for anything else.