Decode matrices in column-major order. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I might try and disable these hlint warnings since the alternative it suggests is more unreadable while being more idiomatic Haskell. |
Yes, please do! |
|
I've just learned how to do it so I'll try and push the build fixes shortly |
|
Oh and please would you double check the matrix definitions? I've already caught myself messing them up twice! |
Matrix definitions LGTM! |
|
I've added a pragma to supress the hlint warnings, but I might need your help to replicate the build failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.
I suppose these will be tested indirectly when I've finished the work on animations, which is the reason why I discovered this one!