feat(HLS): Make dummy streams for tags representing muxed audio #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stream to test it: https://ztnr.rtve.es/ztnr/1694255.m3u8 |
avelad
added
type: enhancement
avelad
force-pushed
the
hls-pick-up-audio-from-video
branch
from
d3a5c12
to
c44eef4
Compare
|
Incremental code coverage: 67.82% |
joeyparrish
reviewed
Sep 19, 2024
theodab
reviewed
Sep 20, 2024
There was a problem hiding this comment.
So, if I'm understanding correctly, this change is making it so that now, we will now make a dummy stream with an empty segment index when we see an audio tag that represents audio that has been muxed into a video stream, correct?
If that's right, I would suggest a title like:
feat(HLS): Make dummy streams for tags representing muxed audio
avelad
changed the title
theodab
approved these changes
Sep 20, 2024
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
joeyparrish
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5836