Add documentation for doc.removeListener #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #147 |
|
@nateps @rkstedman This PR is ready for review. Review delay possibly related to #163 |
|
@nateps @rkstedman @zag2art Any chance of reviewing/commenting on this PR? It should be quick to review and merge, it's only documentation changes. |
|
Hey, it looks fine to me but I'm not in the org. Don't have write access. |
|
@zag2art Thanks for taking a look! |
|
@nateps Kindly requesting review and merge of this small PR that changes documentation only. Thanks! |
rkstedman
approved these changes
Sep 15, 2017
|
@rkstedman Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced a need to use this, as after invoking
doc.destroy(), then invokingdoc.subscribefrom elsewhere, the listeners added before the call todoc.destroy()were still being invoked.