Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasWritePending in op's callback #205

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gkubisa
Copy link
Contributor

@gkubisa gkubisa commented Apr 24, 2018

doc.hasWritePending() should be false in the op's callback after the last operation is complete.

Additionally, checking for this.inflightOp first in this.inflightOp && this.inflightOp.callbacks avoids a TypeError which would happen, if this _otApply failed and caused a hard rollback. Unfortunately, I don't have a test for this situation, as it's a rather obscure edge case.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.163% when pulling 3b17141 on Teamwork:fix-hasWritePending-in-op-callback into ea5053b on share:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.163% when pulling 3b17141 on Teamwork:fix-hasWritePending-in-op-callback into ea5053b on share:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.163% when pulling 3b17141 on Teamwork:fix-hasWritePending-in-op-callback into ea5053b on share:master.

@coveralls
Copy link

coveralls commented Apr 24, 2018

Coverage Status

Coverage decreased (-0.3%) to 96.212% when pulling e117022 on Teamwork:fix-hasWritePending-in-op-callback into 68bde00 on share:master.

@gkubisa
Copy link
Contributor Author

gkubisa commented Jun 11, 2018

@nateps @ericyhwang , could you provide some feedback on this PR, or merge it, if it's all good, please?

@ericyhwang
Copy link
Contributor

Nate from the PR review meeting:

Makes sense. I'll need to read through the rest of the code offline to check a few things [before merging].

@curran
Copy link
Contributor

curran commented Jul 22, 2020

Suggest to close as stale.

@curran curran mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants