⚡️ Deduplicate Backend.getOps() calls
#680
Open
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to `Backend.getOps()` can be quite expensive. In order to minimize the impact of these calls on the server, this change deduplicates concurrent calls with the same arguments, and makes only a single call, then invoking all the callbacks with the single result.
alecgibson
force-pushed
the
deduplicate-get-ops
branch
from
87aa8e3
to
e81522f
Compare
- Clean up `arguments` -> `Array`
ericyhwang
reviewed
Aug 27, 2024
| return function() { | ||
| var args = Array.prototype.slice.call(arguments); | ||
| var callback = args.pop(); | ||
| var argString = JSON.stringify(args); |
There was a problem hiding this comment.
agent.custom could in theory contain non-JSON-serializable objects, and also in practice could result in calls from different clients not being deduped.
We'll have to think on this a bit more - Alec suggested possibly moving it to sharedb-mongo instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
Backend.getOps()can be quite expensive. In order to minimize the impact of these calls on the server, this change deduplicates concurrent calls with the same arguments, and makes only a single call, then invoking all the callbacks with the single result.