Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssh): add logs on ssh connection dialer #4174

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat(ssh): add logs on ssh connection dialer #4174

merged 1 commit into from
Sep 17, 2024

Conversation

henrybarreto
Copy link
Member

No description provided.

@henrybarreto henrybarreto self-assigned this Sep 16, 2024
@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch 2 times, most recently from e049ec2 to c416ad6 Compare September 16, 2024 21:53
@henrybarreto henrybarreto marked this pull request as ready for review September 16, 2024 21:53
@henrybarreto henrybarreto requested a review from a team as a code owner September 16, 2024 21:53
@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch from c416ad6 to 93aae09 Compare September 16, 2024 21:55
@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch from 93aae09 to 838a924 Compare September 17, 2024 12:19
@henrybarreto henrybarreto requested a review from a team as a code owner September 17, 2024 12:19
@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch 4 times, most recently from f1d45e7 to f4fd70d Compare September 17, 2024 13:10
@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch from f4fd70d to b6d3aab Compare September 17, 2024 13:11
otavio
otavio reviewed Sep 17, 2024
View reviewed changes
pkg/revdial/revdial.go Outdated Show resolved Hide resolved
otavio
otavio requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look in few places where you are using uppercase and change to use lowercase consistently.

@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch from b6d3aab to d21c708 Compare September 17, 2024 15:04
@henrybarreto
Copy link
Member Author

Please take a look in few places where you are using uppercase and change to use lowercase consistently.

That is a thing I have noticed too, but it's nice to highlight, mainly on the old logs. Before merging it, I will review and fix these inconsistencies.

@henrybarreto henrybarreto force-pushed the feat/add_log_ssh_connection_related branch from d21c708 to 40c9ca4 Compare September 17, 2024 16:30
@gustavosbarreto gustavosbarreto merged commit f41c78d into master Sep 17, 2024
8 checks passed
@gustavosbarreto gustavosbarreto deleted the feat/add_log_ssh_connection_related branch September 17, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio requested changes

Assignees

@henrybarreto henrybarreto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrybarreto @otavio @gustavosbarreto